Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lambda_event_source_mapping: Additional IAM eventual consistency error message #19831

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19828.

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_SQS'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_SQS -timeout 180m
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (48.59s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (87.21s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (113.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	118.730s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_SQS'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_SQS -timeout 180m
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
=== RUN   TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (56.95s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (106.36s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (141.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.465s

@github-actions github-actions bot added service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. labels Jun 16, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Jun 16, 2021
@YakDriver YakDriver self-assigned this Jun 16, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (67.61s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (91.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (119.28s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_BatchWindow (54.19s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_changesInEnabledAreDetected (86.45s)
--- PASS: TestAccAWSLambdaEventSourceMapping_SQS_basic (147.44s)

@ewbankkit ewbankkit merged commit b4383c4 into main Jun 17, 2021
@ewbankkit ewbankkit deleted the b-aws_lambda_event_source_mapping-iam-eventual-consistency branch June 17, 2021 19:08
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 17, 2021
github-actions bot pushed a commit that referenced this pull request Jun 17, 2021
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_lambda_event_source_mapping depends_on not respected in 3.45 version
2 participants