-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in lb_target_group data source. #19955
Conversation
Relates: #18102. |
.changelog/19955.txt
Outdated
```release-note:bug | ||
data-source/aws_lb_target_group: Add cookie_name attribute for app_cookie support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bug before a release 😄.
```release-note:bug | |
data-source/aws_lb_target_group: Add cookie_name attribute for app_cookie support | |
```release-note:enhancement | |
data-source/aws_lb_target_group: Add `cookie_name` argument for application cookie stickiness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSLBTargetGroup_basic\|TestAccAWSLBTargetGroup_updateAppSticknessEnabled\|TestAccAWSLBTargetGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSLBTargetGroup_basic\|TestAccAWSLBTargetGroup_updateAppSticknessEnabled\|TestAccAWSLBTargetGroup_basic -timeout 180m
=== RUN TestAccDataSourceAWSLBTargetGroup_basic
=== PAUSE TestAccDataSourceAWSLBTargetGroup_basic
=== RUN TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== RUN TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== CONT TestAccDataSourceAWSLBTargetGroup_basic
=== CONT TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== CONT TestAccAWSLBTargetGroup_basicUdp
=== CONT TestAccAWSLBTargetGroup_basic
--- PASS: TestAccAWSLBTargetGroup_basicUdp (23.02s)
--- PASS: TestAccAWSLBTargetGroup_basic (23.05s)
--- PASS: TestAccAWSLBTargetGroup_updateAppSticknessEnabled (58.10s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_basic (224.22s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 227.348s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSLBTargetGroup_basic\|TestAccAWSLBTargetGroup_updateAppSticknessEnabled\|TestAccAWSLBTargetGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSLBTargetGroup_basic\|TestAccAWSLBTargetGroup_updateAppSticknessEnabled\|TestAccAWSLBTargetGroup_basic -timeout 180m
=== RUN TestAccDataSourceAWSLBTargetGroup_basic
=== PAUSE TestAccDataSourceAWSLBTargetGroup_basic
=== RUN TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== RUN TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== PAUSE TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== CONT TestAccDataSourceAWSLBTargetGroup_basic
=== CONT TestAccAWSLBTargetGroup_updateAppSticknessEnabled
=== CONT TestAccAWSLBTargetGroup_basicUdp
=== CONT TestAccAWSLBTargetGroup_basic
--- PASS: TestAccAWSLBTargetGroup_basic (24.13s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (24.18s)
--- PASS: TestAccAWSLBTargetGroup_updateAppSticknessEnabled (61.46s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_basic (173.37s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 176.548s
This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fixes crash in lb_target_group data source and rearranges app_cookie related attributes.
Community Note
Output from acceptance testing: