Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws_appautoscaling_target and aws_appautoscaling_policy resource documentation #2000

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Update aws_appautoscaling_target and aws_appautoscaling_policy resource documentation #2000

merged 2 commits into from
Oct 26, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 21, 2017

  • Use step_scaling_policy_configuration in ECS service autoscaling policy example, fixes Update documentation for "appautoscaling_policy" resource #1933
  • Add DynamoDB table autoscaling examples
  • Add EMR information to policy
  • Provide more readable and verbose table of values for resource_id and scalable_dimension
  • Use nested list for service_namespace

@bflad
Update aws_appautoscaling_target and aws_appautoscaling_policy resour…
f0b78e7 
…ce documentation

* Use step_scaling_policy_configuration in ECS service autoscaling policy example, fixes hashicorp#1933
* Add DynamoDB table autoscaling examples
* Add EMR information to policy
* Provide more readable and verbose table of values for resource_id and scalable_dimension
* Use nested list for service_namespace
@bflad bflad mentioned this pull request Oct 21, 2017
Closed
radeksimko
radeksimko reviewed Oct 23, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example 👍

I left you some questions around sustainability of some other changes. Ideally we'd like the docs to "survive" Amazon's changes and avoid playing the catch-up game, where possible.

Let me know if you can find any places we can reference from our docs instead - if we really can't, then I'm ok with merging this, but it will result in a maintenance burden going forward - hence I'm raising that question.

website/docs/r/appautoscaling_policy.html.markdown Outdated
DynamoDB Table | `table/TABLE` | `table/nameOfTheTable`
EC2 Spot Fleet Request | `spot-fleet-request/ID` | `spot-fleet-request/sfr-73fbd2ce-aa30-494c-8788-1cee4EXAMPLE`
ECS Service | `service/CLUSTER/SERVICE` | `service/default/sample-webapp`
EMR Cluster Instance Group | `instancegroup/CLUSTER/GROUP` | `instancegroup/j-2EEZNYKUA1NTV/ig-1791Y4E1L8YI0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit this confused me for a while when working on DynamoDB autoscaling too, so thanks for mentioning it here. I just wonder - is there any similar table we can link to in the AWS docs instead of keeping our own here?

website/docs/r/appautoscaling_policy.html.markdown Outdated
DynamoDB Table | `dynamodb:table:ReadCapacityUnits`, `dynamodb:table:WriteCapacityUnits`
EC2 Spot Fleet Request | `ec2:spot-fleet-request:TargetCapacity`
ECS Service | `ecs:service:DesiredCount`
EMR Cluster Instance Group | `elasticmapreduce:instancegroup:InstanceCount`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise - is there any place in the AWS docs we can link to?

website/docs/r/appautoscaling_policy.html.markdown Outdated
* `dynamodb`
* `ec2`
* `ecs`
* `elasticmapreduce`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here ^

@radeksimko radeksimko added documentation Introduces or discusses updates to documentation. waiting-response Maintainers are waiting on response from community or contributor. labels Oct 23, 2017
@bflad
Copy link
Contributor Author

bflad commented Oct 25, 2017

@radeksimko thanks for the nudge! Indeed I was able to find comprehensive information on the available values in the application autoscaling API documentation. PR is updated with links instead of tables/lists we need to maintain.

radeksimko
radeksimko approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 26, 2017
@radeksimko radeksimko merged commit d0af71f into hashicorp:master Oct 26, 2017
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation for "appautoscaling_policy" resource
2 participants
@bflad @radeksimko