Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify aws_kms_key.key_usage default value in doc #2006

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

dtan4
Copy link
Contributor

@dtan4 dtan4 commented Oct 22, 2017

The only acceptable value of aws_kms_key 's key_usage is ENCRYPT_DECRYPT, but the document says wrong value.

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Oct 23, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch.

@radeksimko radeksimko merged commit db0414b into hashicorp:master Oct 23, 2017
@dtan4 dtan4 deleted the kms-key-usage-doc branch October 23, 2017 07:30
bflad added a commit to bflad/terraform-provider-aws that referenced this pull request Nov 2, 2017
* remove extraneous id field in schema
* remove extraneous schema timeout definitions
* use isAWSErr instead of manual awserr check
radeksimko pushed a commit that referenced this pull request Nov 7, 2017
* New Resource: aws_ses_template

* Address #2006 PR review comments

* remove extraneous id field in schema
* remove extraneous schema timeout definitions
* use isAWSErr instead of manual awserr check
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants