Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for lambda in ap-northeast-3 #20555

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

bchaja
Copy link
Contributor

@bchaja bchaja commented Aug 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16755

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig -timeout 180m
=== RUN   TestAccAWSLambdaFunction_codeSigningConfig
    resource_aws_lambda_function_test.go:201: Lambda code signing config is not supported in Osaka ap-northeast-3 region us-west-2
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1.399s

Before

resource "aws_iam_role" "iam_for_lambda" {
  name = "role-for-ap-northeast-3"
  assume_role_policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Service": "lambda.amazonaws.com"
      },
      "Action": "sts:AssumeRole"
    }
  ]
}
EOF
}

resource "aws_lambda_function" "test_lambda" {
  filename      = "lambda_function_payload.zip"
  function_name = "test_function"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "handler.lambda_handler"

  runtime = "python3.8"
}

provider "aws" {
  region ="ap-northeast-3"
}

would fail with

Error: error getting Lambda Function (test_function) code signing config AccessDeniedException: 
│       status code: 403, request id: 508a2015-f870-4292-b0f8-eb2b0fb4cb42

@github-actions github-actions bot added service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Aug 13, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bchaja 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@bchaja bchaja marked this pull request as ready for review August 13, 2021 13:54
@Sam-Martin
Copy link

Thank you @bchaja this is really important as without this it's literally impossible to deploy lambda functions to Osaka!

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 17, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN   TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN   TestAccAWSLambdaFunction_codeSigningConfig
=== PAUSE TestAccAWSLambdaFunction_codeSigningConfig
=== RUN   TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== CONT  TestAccAWSLambdaFunction_basic
=== CONT  TestAccAWSLambdaFunction_tracingConfig
=== CONT  TestAccAWSLambdaFunction_codeSigningConfig
--- PASS: TestAccAWSLambdaFunction_basic (51.44s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (67.28s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (78.46s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       82.436s
% AWS_DEFAULT_REGION=ap-northeast-3 make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN   TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN   TestAccAWSLambdaFunction_codeSigningConfig
    resource_aws_lambda_function_test.go:203: Lambda code signing config is not supported in ap-northeast-3 region
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.00s)
=== RUN   TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== CONT  TestAccAWSLambdaFunction_basic
=== CONT  TestAccAWSLambdaFunction_tracingConfig
--- PASS: TestAccAWSLambdaFunction_basic (87.24s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (135.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       138.983s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN   TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN   TestAccAWSLambdaFunction_codeSigningConfig
    resource_aws_lambda_function_test.go:197: Lambda code signing config is not supported in aws-us-gov partition
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.00s)
=== RUN   TestAccAWSLambdaFunction_tracingConfig
    resource_aws_lambda_function_test.go:1004: Lambda tracing config is not supported in aws-us-gov partition
--- SKIP: TestAccAWSLambdaFunction_tracingConfig (0.00s)
=== CONT  TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (36.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.057s

@ewbankkit
Copy link
Contributor

@bchaja Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6f3ce95 into hashicorp:main Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_lambda_function - possible regression w/3.17.0 on us-east-2
3 participants