-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for lambda in ap-northeast-3 #20555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @bchaja 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Thank you @bchaja this is really important as without this it's literally impossible to deploy lambda functions to Osaka! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN TestAccAWSLambdaFunction_codeSigningConfig
=== PAUSE TestAccAWSLambdaFunction_codeSigningConfig
=== RUN TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== CONT TestAccAWSLambdaFunction_basic
=== CONT TestAccAWSLambdaFunction_tracingConfig
=== CONT TestAccAWSLambdaFunction_codeSigningConfig
--- PASS: TestAccAWSLambdaFunction_basic (51.44s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (67.28s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (78.46s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 82.436s
% AWS_DEFAULT_REGION=ap-northeast-3 make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN TestAccAWSLambdaFunction_codeSigningConfig
resource_aws_lambda_function_test.go:203: Lambda code signing config is not supported in ap-northeast-3 region
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.00s)
=== RUN TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== CONT TestAccAWSLambdaFunction_basic
=== CONT TestAccAWSLambdaFunction_tracingConfig
--- PASS: TestAccAWSLambdaFunction_basic (87.24s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (135.85s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 138.983s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_codeSigningConfig\|TestAccAWSLambdaFunction_tracingConfig\|TestAccAWSLambdaFunction_basic -timeout 180m
=== RUN TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN TestAccAWSLambdaFunction_codeSigningConfig
resource_aws_lambda_function_test.go:197: Lambda code signing config is not supported in aws-us-gov partition
--- SKIP: TestAccAWSLambdaFunction_codeSigningConfig (0.00s)
=== RUN TestAccAWSLambdaFunction_tracingConfig
resource_aws_lambda_function_test.go:1004: Lambda tracing config is not supported in aws-us-gov partition
--- SKIP: TestAccAWSLambdaFunction_tracingConfig (0.00s)
=== CONT TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (36.80s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 40.057s
@bchaja Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #16755
Output from acceptance testing:
Before
would fail with