Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventBridge Rule and Target: Allow event_bridge_name to be an ARN #20613

Merged
merged 26 commits into from
Aug 18, 2021
Merged

EventBridge Rule and Target: Allow event_bridge_name to be an ARN #20613

merged 26 commits into from
Aug 18, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 18, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8759.
Closes #19234.
Supersedes #20312.

Output from acceptance testing:

Commercial

% make testacc TESTARGS='-run=TestAccAWSCloudWatchEventArchive_\|TestAccAWSCloudWatchEventPermission_\|TestAccAWSCloudWatchEventRule_\|TestAccAWSCloudWatchEventTarget_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventArchive_\|TestAccAWSCloudWatchEventPermission_\|TestAccAWSCloudWatchEventRule_\|TestAccAWSCloudWatchEventTarget_ -timeout 180m
=== RUN   TestAccAWSCloudWatchEventArchive_basic
=== PAUSE TestAccAWSCloudWatchEventArchive_basic
=== RUN   TestAccAWSCloudWatchEventArchive_update
=== PAUSE TestAccAWSCloudWatchEventArchive_update
=== RUN   TestAccAWSCloudWatchEventArchive_disappears
=== PAUSE TestAccAWSCloudWatchEventArchive_disappears
=== RUN   TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
=== PAUSE TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
=== RUN   TestAccAWSCloudWatchEventPermission_basic
=== PAUSE TestAccAWSCloudWatchEventPermission_basic
=== RUN   TestAccAWSCloudWatchEventPermission_EventBusName
=== PAUSE TestAccAWSCloudWatchEventPermission_EventBusName
=== RUN   TestAccAWSCloudWatchEventPermission_Action
=== PAUSE TestAccAWSCloudWatchEventPermission_Action
=== RUN   TestAccAWSCloudWatchEventPermission_Condition
=== PAUSE TestAccAWSCloudWatchEventPermission_Condition
=== RUN   TestAccAWSCloudWatchEventPermission_Multiple
=== PAUSE TestAccAWSCloudWatchEventPermission_Multiple
=== RUN   TestAccAWSCloudWatchEventPermission_Disappears
=== PAUSE TestAccAWSCloudWatchEventPermission_Disappears
=== RUN   TestAccAWSCloudWatchEventRule_basic
=== PAUSE TestAccAWSCloudWatchEventRule_basic
=== RUN   TestAccAWSCloudWatchEventRule_EventBusName
=== PAUSE TestAccAWSCloudWatchEventRule_EventBusName
=== RUN   TestAccAWSCloudWatchEventRule_role
=== PAUSE TestAccAWSCloudWatchEventRule_role
=== RUN   TestAccAWSCloudWatchEventRule_description
=== PAUSE TestAccAWSCloudWatchEventRule_description
=== RUN   TestAccAWSCloudWatchEventRule_pattern
=== PAUSE TestAccAWSCloudWatchEventRule_pattern
=== RUN   TestAccAWSCloudWatchEventRule_ScheduleAndPattern
=== PAUSE TestAccAWSCloudWatchEventRule_ScheduleAndPattern
=== RUN   TestAccAWSCloudWatchEventRule_NamePrefix
=== PAUSE TestAccAWSCloudWatchEventRule_NamePrefix
=== RUN   TestAccAWSCloudWatchEventRule_Name_Generated
=== PAUSE TestAccAWSCloudWatchEventRule_Name_Generated
=== RUN   TestAccAWSCloudWatchEventRule_tags
=== PAUSE TestAccAWSCloudWatchEventRule_tags
=== RUN   TestAccAWSCloudWatchEventRule_IsEnabled
=== PAUSE TestAccAWSCloudWatchEventRule_IsEnabled
=== RUN   TestAccAWSCloudWatchEventRule_PartnerEventBus
    resource_aws_cloudwatch_event_rule_test.go:497: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccAWSCloudWatchEventRule_PartnerEventBus (0.00s)
=== RUN   TestAccAWSCloudWatchEventRule_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventRule_EventBusArn
=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== RUN   TestAccAWSCloudWatchEventTarget_EventBusName
=== PAUSE TestAccAWSCloudWatchEventTarget_EventBusName
=== RUN   TestAccAWSCloudWatchEventTarget_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventTarget_EventBusArn
=== RUN   TestAccAWSCloudWatchEventTarget_GeneratedTargetId
=== PAUSE TestAccAWSCloudWatchEventTarget_GeneratedTargetId
=== RUN   TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
=== PAUSE TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
=== RUN   TestAccAWSCloudWatchEventTarget_full
=== PAUSE TestAccAWSCloudWatchEventTarget_full
=== RUN   TestAccAWSCloudWatchEventTarget_disappears
=== PAUSE TestAccAWSCloudWatchEventTarget_disappears
=== RUN   TestAccAWSCloudWatchEventTarget_ssmDocument
=== PAUSE TestAccAWSCloudWatchEventTarget_ssmDocument
=== RUN   TestAccAWSCloudWatchEventTarget_http
=== PAUSE TestAccAWSCloudWatchEventTarget_http
=== RUN   TestAccAWSCloudWatchEventTarget_ecs
=== PAUSE TestAccAWSCloudWatchEventTarget_ecs
=== RUN   TestAccAWSCloudWatchEventTarget_redshift
=== PAUSE TestAccAWSCloudWatchEventTarget_redshift
=== RUN   TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
=== RUN   TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
=== RUN   TestAccAWSCloudWatchEventTarget_ecsFull
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsFull
=== RUN   TestAccAWSCloudWatchEventTarget_batch
=== PAUSE TestAccAWSCloudWatchEventTarget_batch
=== RUN   TestAccAWSCloudWatchEventTarget_kinesis
=== PAUSE TestAccAWSCloudWatchEventTarget_kinesis
=== RUN   TestAccAWSCloudWatchEventTarget_sqs
=== PAUSE TestAccAWSCloudWatchEventTarget_sqs
=== RUN   TestAccAWSCloudWatchEventTarget_input_transformer
=== PAUSE TestAccAWSCloudWatchEventTarget_input_transformer
=== RUN   TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
=== PAUSE TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
=== RUN   TestAccAWSCloudWatchEventTarget_PartnerEventBus
    resource_aws_cloudwatch_event_target_test.go:819: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccAWSCloudWatchEventTarget_PartnerEventBus (0.00s)
=== CONT  TestAccAWSCloudWatchEventArchive_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
=== CONT  TestAccAWSCloudWatchEventTarget_redshift
=== CONT  TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
=== CONT  TestAccAWSCloudWatchEventRule_EventBusName
=== CONT  TestAccAWSCloudWatchEventTarget_input_transformer
=== CONT  TestAccAWSCloudWatchEventTarget_sqs
=== CONT  TestAccAWSCloudWatchEventTarget_kinesis
=== CONT  TestAccAWSCloudWatchEventTarget_batch
=== CONT  TestAccAWSCloudWatchEventTarget_ecsFull
=== CONT  TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
=== CONT  TestAccAWSCloudWatchEventTarget_full
=== CONT  TestAccAWSCloudWatchEventTarget_ecs
=== CONT  TestAccAWSCloudWatchEventTarget_http
=== CONT  TestAccAWSCloudWatchEventTarget_ssmDocument
=== CONT  TestAccAWSCloudWatchEventTarget_disappears
=== CONT  TestAccAWSCloudWatchEventTarget_GeneratedTargetId
=== CONT  TestAccAWSCloudWatchEventTarget_EventBusArn
=== CONT  TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (35.88s)
=== CONT  TestAccAWSCloudWatchEventTarget_EventBusName
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (41.78s)
=== CONT  TestAccAWSCloudWatchEventPermission_Action
--- PASS: TestAccAWSCloudWatchEventArchive_basic (45.18s)
=== CONT  TestAccAWSCloudWatchEventRule_NamePrefix
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (49.22s)
=== CONT  TestAccAWSCloudWatchEventRule_basic
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (54.29s)
=== CONT  TestAccAWSCloudWatchEventRule_EventBusArn
--- PASS: TestAccAWSCloudWatchEventTarget_http (62.85s)
=== CONT  TestAccAWSCloudWatchEventPermission_Disappears
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusArn (64.13s)
=== CONT  TestAccAWSCloudWatchEventRule_IsEnabled
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount (78.50s)
=== CONT  TestAccAWSCloudWatchEventPermission_Multiple
--- PASS: TestAccAWSCloudWatchEventTarget_ecsFull (84.47s)
=== CONT  TestAccAWSCloudWatchEventRule_tags
--- PASS: TestAccAWSCloudWatchEventRule_NamePrefix (70.11s)
=== CONT  TestAccAWSCloudWatchEventPermission_Condition
--- PASS: TestAccAWSCloudWatchEventTarget_full (119.77s)
=== CONT  TestAccAWSCloudWatchEventRule_Name_Generated
--- PASS: TestAccAWSCloudWatchEventPermission_Action (83.78s)
=== CONT  TestAccAWSCloudWatchEventRule_pattern
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (130.24s)
=== CONT  TestAccAWSCloudWatchEventRule_ScheduleAndPattern
--- PASS: TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig (133.02s)
=== CONT  TestAccAWSCloudWatchEventRule_description
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (133.02s)
=== CONT  TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
--- PASS: TestAccAWSCloudWatchEventRule_EventBusArn (79.04s)
=== CONT  TestAccAWSCloudWatchEventPermission_EventBusName
--- PASS: TestAccAWSCloudWatchEventTarget_basic (155.71s)
=== CONT  TestAccAWSCloudWatchEventPermission_basic
--- PASS: TestAccAWSCloudWatchEventRule_EventBusName (163.45s)
=== CONT  TestAccAWSCloudWatchEventArchive_disappears
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (141.65s)
=== CONT  TestAccAWSCloudWatchEventRule_role
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (179.49s)
=== CONT  TestAccAWSCloudWatchEventArchive_update
--- PASS: TestAccAWSCloudWatchEventRule_Name_Generated (73.86s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (117.87s)
--- PASS: TestAccAWSCloudWatchEventRule_ScheduleAndPattern (73.42s)
--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (73.34s)
--- PASS: TestAccAWSCloudWatchEventArchive_retentionSetOnCreation (73.87s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (208.12s)
--- PASS: TestAccAWSCloudWatchEventArchive_disappears (57.70s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (174.64s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (108.63s)
--- PASS: TestAccAWSCloudWatchEventRule_pattern (104.89s)
--- PASS: TestAccAWSCloudWatchEventRule_description (101.03s)
--- PASS: TestAccAWSCloudWatchEventRule_IsEnabled (169.96s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (172.14s)
--- PASS: TestAccAWSCloudWatchEventRule_role (64.48s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType (242.85s)
--- PASS: TestAccAWSCloudWatchEventArchive_update (72.79s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (172.53s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (104.07s)
--- PASS: TestAccAWSCloudWatchEventTarget_redshift (762.13s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       766.348s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSCloudWatchEventArchive_\|TestAccAWSCloudWatchEventPermission_\|TestAccAWSCloudWatchEventRule_\|TestAccAWSCloudWatchEventTarget_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventArchive_\|TestAccAWSCloudWatchEventPermission_\|TestAccAWSCloudWatchEventRule_\|TestAccAWSCloudWatchEventTarget_ -timeout 180m
=== RUN   TestAccAWSCloudWatchEventArchive_basic
=== PAUSE TestAccAWSCloudWatchEventArchive_basic
=== RUN   TestAccAWSCloudWatchEventArchive_update
=== PAUSE TestAccAWSCloudWatchEventArchive_update
=== RUN   TestAccAWSCloudWatchEventArchive_disappears
=== PAUSE TestAccAWSCloudWatchEventArchive_disappears
=== RUN   TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
=== PAUSE TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
=== RUN   TestAccAWSCloudWatchEventPermission_basic
=== PAUSE TestAccAWSCloudWatchEventPermission_basic
=== RUN   TestAccAWSCloudWatchEventPermission_EventBusName
=== PAUSE TestAccAWSCloudWatchEventPermission_EventBusName
=== RUN   TestAccAWSCloudWatchEventPermission_Action
=== PAUSE TestAccAWSCloudWatchEventPermission_Action
=== RUN   TestAccAWSCloudWatchEventPermission_Condition
=== PAUSE TestAccAWSCloudWatchEventPermission_Condition
=== RUN   TestAccAWSCloudWatchEventPermission_Multiple
=== PAUSE TestAccAWSCloudWatchEventPermission_Multiple
=== RUN   TestAccAWSCloudWatchEventPermission_Disappears
=== PAUSE TestAccAWSCloudWatchEventPermission_Disappears
=== RUN   TestAccAWSCloudWatchEventRule_basic
=== PAUSE TestAccAWSCloudWatchEventRule_basic
=== RUN   TestAccAWSCloudWatchEventRule_EventBusName
=== PAUSE TestAccAWSCloudWatchEventRule_EventBusName
=== RUN   TestAccAWSCloudWatchEventRule_role
=== PAUSE TestAccAWSCloudWatchEventRule_role
=== RUN   TestAccAWSCloudWatchEventRule_description
=== PAUSE TestAccAWSCloudWatchEventRule_description
=== RUN   TestAccAWSCloudWatchEventRule_pattern
=== PAUSE TestAccAWSCloudWatchEventRule_pattern
=== RUN   TestAccAWSCloudWatchEventRule_ScheduleAndPattern
=== PAUSE TestAccAWSCloudWatchEventRule_ScheduleAndPattern
=== RUN   TestAccAWSCloudWatchEventRule_NamePrefix
=== PAUSE TestAccAWSCloudWatchEventRule_NamePrefix
=== RUN   TestAccAWSCloudWatchEventRule_Name_Generated
=== PAUSE TestAccAWSCloudWatchEventRule_Name_Generated
=== RUN   TestAccAWSCloudWatchEventRule_tags
=== PAUSE TestAccAWSCloudWatchEventRule_tags
=== RUN   TestAccAWSCloudWatchEventRule_IsEnabled
=== PAUSE TestAccAWSCloudWatchEventRule_IsEnabled
=== RUN   TestAccAWSCloudWatchEventRule_PartnerEventBus
    resource_aws_cloudwatch_event_rule_test.go:497: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccAWSCloudWatchEventRule_PartnerEventBus (0.00s)
=== RUN   TestAccAWSCloudWatchEventRule_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventRule_EventBusArn
=== RUN   TestAccAWSCloudWatchEventTarget_basic
=== PAUSE TestAccAWSCloudWatchEventTarget_basic
=== RUN   TestAccAWSCloudWatchEventTarget_EventBusName
=== PAUSE TestAccAWSCloudWatchEventTarget_EventBusName
=== RUN   TestAccAWSCloudWatchEventTarget_EventBusArn
=== PAUSE TestAccAWSCloudWatchEventTarget_EventBusArn
=== RUN   TestAccAWSCloudWatchEventTarget_GeneratedTargetId
=== PAUSE TestAccAWSCloudWatchEventTarget_GeneratedTargetId
=== RUN   TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
=== PAUSE TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
=== RUN   TestAccAWSCloudWatchEventTarget_full
=== PAUSE TestAccAWSCloudWatchEventTarget_full
=== RUN   TestAccAWSCloudWatchEventTarget_disappears
=== PAUSE TestAccAWSCloudWatchEventTarget_disappears
=== RUN   TestAccAWSCloudWatchEventTarget_ssmDocument
=== PAUSE TestAccAWSCloudWatchEventTarget_ssmDocument
=== RUN   TestAccAWSCloudWatchEventTarget_http
=== PAUSE TestAccAWSCloudWatchEventTarget_http
=== RUN   TestAccAWSCloudWatchEventTarget_ecs
=== PAUSE TestAccAWSCloudWatchEventTarget_ecs
=== RUN   TestAccAWSCloudWatchEventTarget_redshift
=== PAUSE TestAccAWSCloudWatchEventTarget_redshift
=== RUN   TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
=== RUN   TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
=== RUN   TestAccAWSCloudWatchEventTarget_ecsFull
=== PAUSE TestAccAWSCloudWatchEventTarget_ecsFull
=== RUN   TestAccAWSCloudWatchEventTarget_batch
=== PAUSE TestAccAWSCloudWatchEventTarget_batch
=== RUN   TestAccAWSCloudWatchEventTarget_kinesis
=== PAUSE TestAccAWSCloudWatchEventTarget_kinesis
=== RUN   TestAccAWSCloudWatchEventTarget_sqs
=== PAUSE TestAccAWSCloudWatchEventTarget_sqs
=== RUN   TestAccAWSCloudWatchEventTarget_input_transformer
=== PAUSE TestAccAWSCloudWatchEventTarget_input_transformer
=== RUN   TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
=== PAUSE TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
=== RUN   TestAccAWSCloudWatchEventTarget_PartnerEventBus
    resource_aws_cloudwatch_event_target_test.go:819: Environment variable EVENT_BRIDGE_PARTNER_EVENT_BUS_NAME is not set
--- SKIP: TestAccAWSCloudWatchEventTarget_PartnerEventBus (0.00s)
=== CONT  TestAccAWSCloudWatchEventArchive_basic
=== CONT  TestAccAWSCloudWatchEventTarget_basic
=== CONT  TestAccAWSCloudWatchEventRule_EventBusName
=== CONT  TestAccAWSCloudWatchEventArchive_update
=== CONT  TestAccAWSCloudWatchEventPermission_Action
=== CONT  TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
=== CONT  TestAccAWSCloudWatchEventRule_basic
=== CONT  TestAccAWSCloudWatchEventPermission_Disappears
=== CONT  TestAccAWSCloudWatchEventPermission_Multiple
=== CONT  TestAccAWSCloudWatchEventPermission_basic
=== CONT  TestAccAWSCloudWatchEventPermission_Condition
=== CONT  TestAccAWSCloudWatchEventRule_NamePrefix
=== CONT  TestAccAWSCloudWatchEventRule_EventBusArn
=== CONT  TestAccAWSCloudWatchEventRule_IsEnabled
=== CONT  TestAccAWSCloudWatchEventRule_tags
=== CONT  TestAccAWSCloudWatchEventArchive_disappears
=== CONT  TestAccAWSCloudWatchEventTarget_redshift
=== CONT  TestAccAWSCloudWatchEventRule_Name_Generated
=== CONT  TestAccAWSCloudWatchEventTarget_full
=== CONT  TestAccAWSCloudWatchEventPermission_EventBusName
=== CONT  TestAccAWSCloudWatchEventArchive_retentionSetOnCreation
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Archive failed: UnknownOperationException: Operation is disabled in this region.
        	status code: 400, request id: 1b76a05e-c9dd-4700-9331-73bd25b40ae5
        
          with aws_cloudwatch_event_archive.test,
          on terraform_plugin_test.tf line 6, in resource "aws_cloudwatch_event_archive" "test":
           6: resource "aws_cloudwatch_event_archive" "test" {
        
=== CONT  TestAccAWSCloudWatchEventArchive_basic
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Archive failed: UnknownOperationException: Operation is disabled in this region.
        	status code: 400, request id: 8bf1adc7-0b31-46e3-b4b0-acf43c468fc8
        
          with aws_cloudwatch_event_archive.test,
          on terraform_plugin_test.tf line 6, in resource "aws_cloudwatch_event_archive" "test":
           6: resource "aws_cloudwatch_event_archive" "test" {
        
=== CONT  TestAccAWSCloudWatchEventArchive_disappears
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Archive failed: UnknownOperationException: Operation is disabled in this region.
        	status code: 400, request id: 3f6e2668-2d5e-4238-9ee2-cd5b87df45f1
        
          with aws_cloudwatch_event_archive.test,
          on terraform_plugin_test.tf line 6, in resource "aws_cloudwatch_event_archive" "test":
           6: resource "aws_cloudwatch_event_archive" "test" {
        
=== CONT  TestAccAWSCloudWatchEventArchive_update
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Archive failed: UnknownOperationException: Operation is disabled in this region.
        	status code: 400, request id: 18fcd295-879e-48df-9fa0-29d991e0bebd
        
          with aws_cloudwatch_event_archive.test,
          on terraform_plugin_test.tf line 6, in resource "aws_cloudwatch_event_archive" "test":
           6: resource "aws_cloudwatch_event_archive" "test" {
        
--- SKIP: TestAccAWSCloudWatchEventArchive_retentionSetOnCreation (48.42s)
=== CONT  TestAccAWSCloudWatchEventTarget_inputTransformerJsonString
--- SKIP: TestAccAWSCloudWatchEventArchive_basic (50.08s)
=== CONT  TestAccAWSCloudWatchEventTarget_input_transformer
--- SKIP: TestAccAWSCloudWatchEventArchive_update (51.01s)
=== CONT  TestAccAWSCloudWatchEventTarget_sqs
--- SKIP: TestAccAWSCloudWatchEventArchive_disappears (52.21s)
=== CONT  TestAccAWSCloudWatchEventTarget_kinesis
--- PASS: TestAccAWSCloudWatchEventRule_NamePrefix (95.05s)
=== CONT  TestAccAWSCloudWatchEventTarget_batch
--- PASS: TestAccAWSCloudWatchEventRule_Name_Generated (98.75s)
=== CONT  TestAccAWSCloudWatchEventTarget_ecsFull
--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (101.91s)
=== CONT  TestAccAWSCloudWatchEventTarget_ecsWithBlankTaskCount
--- PASS: TestAccAWSCloudWatchEventRule_EventBusArn (102.35s)
=== CONT  TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType
--- PASS: TestAccAWSCloudWatchEventPermission_Action (108.68s)
=== CONT  TestAccAWSCloudWatchEventRule_pattern
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (136.67s)
=== CONT  TestAccAWSCloudWatchEventTarget_http
--- PASS: TestAccAWSCloudWatchEventTarget_full (141.27s)
=== CONT  TestAccAWSCloudWatchEventRule_ScheduleAndPattern
--- PASS: TestAccAWSCloudWatchEventTarget_sqs (90.49s)
=== CONT  TestAccAWSCloudWatchEventTarget_ecs
--- PASS: TestAccAWSCloudWatchEventTarget_inputTransformerJsonString (96.69s)
=== CONT  TestAccAWSCloudWatchEventTarget_ssmDocument
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (147.83s)
=== CONT  TestAccAWSCloudWatchEventTarget_disappears
=== CONT  TestAccAWSCloudWatchEventTarget_http
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Error creating API Gateway: BadRequestException: Endpoint Configuration type EDGE is not supported in this region: us-gov-west-1
        
          with aws_api_gateway_rest_api.test,
          on terraform_plugin_test.tf line 25, in resource "aws_api_gateway_rest_api" "test":
          25: resource "aws_api_gateway_rest_api" "test" {
        
--- PASS: TestAccAWSCloudWatchEventTarget_input_transformer (117.44s)
=== CONT  TestAccAWSCloudWatchEventTarget_GeneratedTargetId
--- SKIP: TestAccAWSCloudWatchEventTarget_http (36.78s)
=== CONT  TestAccAWSCloudWatchEventRule_description
--- PASS: TestAccAWSCloudWatchEventTarget_kinesis (133.67s)
=== CONT  TestAccAWSCloudWatchEventRule_role
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (193.54s)
=== CONT  TestAccAWSCloudWatchEventTarget_EventBusArn
--- PASS: TestAccAWSCloudWatchEventTarget_ecsFull (101.19s)
=== CONT  TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
--- PASS: TestAccAWSCloudWatchEventPermission_basic (206.38s)
=== CONT  TestAccAWSCloudWatchEventTarget_EventBusName
--- PASS: TestAccAWSCloudWatchEventRule_basic (212.27s)
--- PASS: TestAccAWSCloudWatchEventRule_IsEnabled (213.00s)
--- PASS: TestAccAWSCloudWatchEventTarget_basic (213.74s)
--- PASS: TestAccAWSCloudWatchEventTarget_disappears (66.36s)
--- PASS: TestAccAWSCloudWatchEventRule_ScheduleAndPattern (73.32s)
=== CONT   TestAccAWSCloudWatchEventTarget_EventBusArn
    resource_aws_cloudwatch_event_target_test.go:226: CloudWatch Events Target EventBus ARNs are not supported in aws-us-gov partition
--- SKIP: TestAccAWSCloudWatchEventTarget_EventBusArn (0.00s)
--- PASS: TestAccAWSCloudWatchEventRule_EventBusName (220.01s)
--- PASS: TestAccAWSCloudWatchEventTarget_ssmDocument (75.81s)
--- PASS: TestAccAWSCloudWatchEventRule_pattern (115.48s)
--- PASS: TestAccAWSCloudWatchEventTarget_GeneratedTargetId (57.86s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (230.47s)
--- PASS: TestAccAWSCloudWatchEventRule_role (52.29s)
--- PASS: TestAccAWSCloudWatchEventRule_description (67.59s)
=== CONT  TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Target failed: UnknownOperationException: Operation is disabled in this region.
        	status code: 400, request id: 339e6eeb-b58b-4404-8aba-f53454532fa8
        
          with aws_cloudwatch_event_target.test,
          on terraform_plugin_test.tf line 54, in resource "aws_cloudwatch_event_target" "test":
          54: resource "aws_cloudwatch_event_target" "test" {
        
--- PASS: TestAccAWSCloudWatchEventTarget_EventBusName (49.78s)
--- PASS: TestAccAWSCloudWatchEventTarget_ecsWithBlankLaunchType (154.69s)
--- SKIP: TestAccAWSCloudWatchEventTarget_RetryPolicy_DeadLetterConfig (65.49s)
--- PASS: TestAccAWSCloudWatchEventTarget_batch (181.88s)
=== CONT  TestAccAWSCloudWatchEventTarget_redshift
    provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: Creating CloudWatch Events Target failed: ValidationException: redshift_data is not a supported service for a target.
        	status code: 400, request id: 2cd181d7-2ee0-4536-93be-1482a25a1f4f
        
          with aws_cloudwatch_event_target.test,
          on terraform_plugin_test.tf line 95, in resource "aws_cloudwatch_event_target" "test":
          95: resource "aws_cloudwatch_event_target" "test" {
        
--- SKIP: TestAccAWSCloudWatchEventTarget_redshift (962.88s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws	970.939s

richardowen and others added 22 commits August 18, 2021 10:03
@richardowen @ewbankkit
Delete dependabot.yml
7855810
@francesco-fucile @ewbankkit
Add acceptance test for AWS EventBridge event bus configuration using…
cb7fa83 
… an ARN as event_bus_name.
@francesco-fucile @ewbankkit
EventBridge event bus rule, READ operation: update rule ID validation…
d43189f 
… to accept event bus ARN.
@francesco-fucile @ewbankkit
Fix TestAccAWSCloudWatchEventRule_EventBusArn test.
2f31161
@francesco-fucile @ewbankkit
Update READ function for event bus rule to preserve event bus ARNs.
3cdda95
@francesco-fucile @ewbankkit
Don't import event bus rule on test.
1a687b8
@francesco-fucile @ewbankkit
Reintroduce import tests for event bus rule.
2e157d2
@francesco-fucile @ewbankkit
Allow for setting event_bus_name as ARN for aws_cloudwatch_event_target.
827a419
@francesco-fucile @ewbankkit
Fix EventBusArn event bus target test.
7745f2d
@francesco-fucile @ewbankkit
Revert "Delete dependabot.yml"
8ce9944 
This reverts commit d3fe849.
@francesco-fucile @ewbankkit
Add new TF configuration for event bus rule with arn test.
f80e5f1
@francesco-fucile @ewbankkit
Fix typo on event rule test.
62f5d87
@francesco-fucile @ewbankkit
Remove event bus rule dependency on AWS_DEFAULT_REGION env var.
1a2803d
@francesco-fucile @ewbankkit
Fix event target test.
9c61947
@francesco-fucile @ewbankkit
Remove reliance on EVENT_BRIDGE_EVENT_BUS_ARN env var.
5c40bc6
@francesco-fucile @ewbankkit
Remove unused function.
4388369
@francesco-fucile @ewbankkit
Rename parameters for test function for clarity.
1d5487d
@ewbankkit
Add CHANGELOG entry.
a0e8d69
@ewbankkit
Rename CloudWatch Events resource ID functions.
1770fa3
@ewbankkit
Support event bus ARN when parsing Rule resource ID and Target import…
aba89ae 
… ID.
@ewbankkit
Consistently use 'events' as an import alias for 'github.com/aws/aws-…
9c33e57 
…sdk-go/service/cloudwatchevents'.
@ewbankkit
r/aws_cloudwatch_event_rule: Use event bus name from resource ID as A…
8aa6c44 
…PI response may collapse any ARN.
@ewbankkit ewbankkit changed the title EventBridge Rule and Target: Allow event_bridge_name to be an ARN [WIP] EventBridge Rule and Target: Allow event_bridge_name to be an ARN Aug 18, 2021
@github-actions github-actions bot added service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 18, 2021
@ewbankkit ewbankkit changed the title [WIP] EventBridge Rule and Target: Allow event_bridge_name to be an ARN EventBridge Rule and Target: Allow event_bridge_name to be an ARN Aug 18, 2021
@ewbankkit ewbankkit merged commit 71edd71 into main Aug 18, 2021
@ewbankkit ewbankkit deleted the tmp-pr20312 branch August 18, 2021 20:28
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 18, 2021
github-actions bot pushed a commit that referenced this pull request Aug 18, 2021
Update CHANGELOG.md for #20613
29338bf
@ewbankkit ewbankkit mentioned this pull request Aug 18, 2021
Closed
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.55.0
3 participants
@ewbankkit @richardowen @francesco-fucile