Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_kinesis_firehose_delivery_stream_test: Fixed ExternalId being a random int #2079

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Oct 27, 2017

This fixes a bug where the ExternalId for a policy was a random int passed rather than the actual account id.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource -timeout 120m
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (145.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.179s

@Ninir Ninir requested a review from radeksimko October 27, 2017 09:28
@Ninir Ninir added the bug Addresses a defect in current functionality. label Oct 27, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I somehow missed that - thanks!

@Ninir Ninir merged commit b3c6f76 into hashicorp:master Oct 27, 2017
@Ninir Ninir deleted the b-firehosestreamsource-accountid branch October 27, 2017 10:55
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants