Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudwatch_log_metric_filter: fixed flattenCloudWachLogMetricTransformations return value #2086

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Oct 27, 2017

This updates the flattenCloudWachLogMetricTransformations method.
Until now, the d.Set("metric_transformation") for this particular structure was not working as expected: the value passed was just never set, meaning you could not update one of the structure value in the console, making Terraform be aware of it at plan-time. The value stored in the state only depended on the value set by the user in the configuration file.

Required for #1578

@Ninir Ninir added the bug Addresses a defect in current functionality. label Oct 27, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume that the only way we can test this is by adding import functionality + import test which seems way out of scope of this PR.

@Ninir
Copy link
Contributor Author

Ninir commented Oct 30, 2017

@radeksimko Indeed!

will merge then, thanks :)

@Ninir Ninir merged commit cea6bd7 into hashicorp:master Oct 30, 2017
@Ninir Ninir deleted the b-cw-logmetricfilter-read branch October 30, 2017 08:41
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants