Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore dependency vendoring for awsproviderlint #21114

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Restore dependency vendoring for awsproviderlint #21114

merged 3 commits into from
Oct 5, 2021

Conversation

gdavison
Copy link
Contributor

Turns out that the vendor directory was needed, since the testing framework for the go/analysis framework does not work with Go modules.

Relates #21078

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/location Issues and PRs that pertain to the location service. service/s3 Issues and PRs that pertain to the s3 service. labels Sep 30, 2021
@gdavison gdavison force-pushed the unvendor-awsproviderlint branch from b3d08f9 to f1fcac2 Compare October 5, 2021 00:45
ewbankkit
ewbankkit approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@YakDriver
Copy link
Member

😞

@justinretzolk justinretzolk mentioned this pull request Oct 5, 2021
Merged
@gdavison gdavison merged commit bf09414 into main Oct 5, 2021
@gdavison gdavison deleted the unvendor-awsproviderlint branch October 5, 2021 17:44
@github-actions github-actions bot added this to the v3.62.0 milestone Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/lambda Issues and PRs that pertain to the lambda service. service/location Issues and PRs that pertain to the location service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.62.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @YakDriver @ewbankkit