Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_email_identity - move to sesv2 #21208

Closed

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Oct 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21129. In order to support new attributes, it is required to use sesv2 package from AWS SDK. I'm going to add these attributes in the next PR.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccSESEmailIdentity" PKG_NAME="internal/service/ses"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ses -v -count 1 -parallel 20 -run=TestAccSESEmailIdentity -timeout 180m
=== RUN   TestAccSESEmailIdentity_basic
=== PAUSE TestAccSESEmailIdentity_basic
=== RUN   TestAccSESEmailIdentity_trailingPeriod
=== PAUSE TestAccSESEmailIdentity_trailingPeriod
=== CONT  TestAccSESEmailIdentity_basic
=== CONT  TestAccSESEmailIdentity_trailingPeriod
--- PASS: TestAccSESEmailIdentity_trailingPeriod (29.60s)
--- PASS: TestAccSESEmailIdentity_basic (29.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	36.585s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 7, 2021
@kamilturek kamilturek marked this pull request as ready for review October 7, 2021 21:35
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 7, 2021
@kamilturek kamilturek force-pushed the td-aws_ses_email_identity_v2 branch from 9d98dd8 to f2d85cb Compare October 16, 2021 10:55
@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 16, 2021
@kamilturek
Copy link
Collaborator Author

Rebased due to recent package changes.

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@kamilturek kamilturek changed the title d/ses_email_identity - move to sesv2 r/ses_email_identity - move to sesv2 Oct 20, 2021
@kamilturek kamilturek closed this Feb 11, 2022
@kamilturek kamilturek deleted the td-aws_ses_email_identity_v2 branch February 11, 2022 16:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants