Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Restores unused code linting for Service Packages #21330

Merged
merged 2 commits into from
Oct 18, 2021
Merged

linting: Restores unused code linting for Service Packages #21330

merged 2 commits into from
Oct 18, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 15, 2021 •
edited
Loading

Restores the deadcode and varcheck linters

Relates #20000

@github-actions github-actions bot added service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/guardduty Issues and PRs that pertain to the guardduty service. service/kafka Issues and PRs that pertain to the kafka service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/redshift Issues and PRs that pertain to the redshift service. service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Oct 15, 2021
anGie44
anGie44 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit ab85b1c into main Oct 18, 2021
@gdavison gdavison deleted the svcpkg-linting-deadcode branch October 18, 2021 20:19
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/guardduty Issues and PRs that pertain to the guardduty service. service/kafka Issues and PRs that pertain to the kafka service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/redshift Issues and PRs that pertain to the redshift service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @anGie44