-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator/tags: include PropagateAtLaunch
key in TagData for autoscaling
#21364
Conversation
PropagateAtLaunch
key when getting tagsPropagateAtLaunch
key in TagData
PropagateAtLaunch
key in TagDataPropagateAtLaunch
key in TagData for autoscaling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags' PKG_NAME=internal/service/autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling -v -count 1 -parallel 20 -run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags -timeout 180m
=== RUN TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN TestAccAutoScalingGroupTag_basic
=== PAUSE TestAccAutoScalingGroupTag_basic
=== RUN TestAccAutoScalingGroupTag_disappears
=== PAUSE TestAccAutoScalingGroupTag_disappears
=== RUN TestAccAutoScalingGroupTag_value
=== PAUSE TestAccAutoScalingGroupTag_value
=== RUN TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== CONT TestAccAutoScalingAttachment_albTargetGroup
=== CONT TestAccAutoScalingGroup_tags
=== CONT TestAccAutoScalingGroupTag_disappears
=== CONT TestAccAutoScalingGroupTag_basic
=== CONT TestAccAutoScalingGroupTag_value
--- PASS: TestAccAutoScalingGroupTag_disappears (65.93s)
--- PASS: TestAccAutoScalingGroupTag_basic (70.14s)
--- PASS: TestAccAutoScalingGroupTag_value (112.36s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (230.23s)
--- PASS: TestAccAutoScalingGroup_tags (261.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 268.059s
GovCloud
% make testacc TESTARGS='-run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags' PKG_NAME=internal/service/autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling -v -count 1 -parallel 20 -run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags -timeout 180m
=== RUN TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN TestAccAutoScalingGroupTag_basic
=== PAUSE TestAccAutoScalingGroupTag_basic
=== RUN TestAccAutoScalingGroupTag_disappears
=== PAUSE TestAccAutoScalingGroupTag_disappears
=== RUN TestAccAutoScalingGroupTag_value
=== PAUSE TestAccAutoScalingGroupTag_value
=== RUN TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== CONT TestAccAutoScalingAttachment_albTargetGroup
=== CONT TestAccAutoScalingGroup_tags
=== CONT TestAccAutoScalingGroupTag_disappears
=== CONT TestAccAutoScalingGroupTag_value
=== CONT TestAccAutoScalingGroupTag_basic
--- PASS: TestAccAutoScalingGroupTag_disappears (42.11s)
--- PASS: TestAccAutoScalingGroupTag_basic (70.47s)
--- PASS: TestAccAutoScalingGroupTag_value (91.87s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (171.50s)
--- PASS: TestAccAutoScalingGroup_tags (220.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 227.410s
This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21306
Output from acceptance testing (previously failing in CI):