Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator/tags: include PropagateAtLaunch key in TagData for autoscaling #21364

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Oct 19, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21306

Output from acceptance testing (previously failing in CI):

--- PASS: TestAccAutoScalingGroupTag_value (87.85s)
--- PASS: TestAccAutoScalingGroupTag_basic (61.49s)
--- PASS: TestAccAutoScalingGroupTag_disappears (67.51s)

--- PASS: TestAccAutoScalingAttachment_albTargetGroup (162.91s)

--- PASS: TestAccAutoScalingGroup_tags (286.11s)

@github-actions github-actions bot added generators Relates to code generators. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. labels Oct 19, 2021
@anGie44 anGie44 changed the title service/autoscaling: include PropagateAtLaunch key when getting tags service/autoscaling: include PropagateAtLaunch key in TagData Oct 19, 2021
@anGie44 anGie44 changed the title service/autoscaling: include PropagateAtLaunch key in TagData generator/tags: include PropagateAtLaunch key in TagData for autoscaling Oct 19, 2021
@ewbankkit ewbankkit assigned ewbankkit and unassigned ewbankkit Oct 19, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags' PKG_NAME=internal/service/autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling -v -count 1 -parallel 20 -run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags -timeout 180m
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN   TestAccAutoScalingGroupTag_basic
=== PAUSE TestAccAutoScalingGroupTag_basic
=== RUN   TestAccAutoScalingGroupTag_disappears
=== PAUSE TestAccAutoScalingGroupTag_disappears
=== RUN   TestAccAutoScalingGroupTag_value
=== PAUSE TestAccAutoScalingGroupTag_value
=== RUN   TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingGroup_tags
=== CONT  TestAccAutoScalingGroupTag_disappears
=== CONT  TestAccAutoScalingGroupTag_basic
=== CONT  TestAccAutoScalingGroupTag_value
--- PASS: TestAccAutoScalingGroupTag_disappears (65.93s)
--- PASS: TestAccAutoScalingGroupTag_basic (70.14s)
--- PASS: TestAccAutoScalingGroupTag_value (112.36s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (230.23s)
--- PASS: TestAccAutoScalingGroup_tags (261.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	268.059s
GovCloud
% make testacc TESTARGS='-run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags' PKG_NAME=internal/service/autoscaling 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling -v -count 1 -parallel 20 -run=TestAccAutoScalingGroupTag_\|TestAccAutoScalingAttachment_albTargetGroup\|TestAccAutoScalingGroup_tags -timeout 180m
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN   TestAccAutoScalingGroupTag_basic
=== PAUSE TestAccAutoScalingGroupTag_basic
=== RUN   TestAccAutoScalingGroupTag_disappears
=== PAUSE TestAccAutoScalingGroupTag_disappears
=== RUN   TestAccAutoScalingGroupTag_value
=== PAUSE TestAccAutoScalingGroupTag_value
=== RUN   TestAccAutoScalingGroup_tags
=== PAUSE TestAccAutoScalingGroup_tags
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingGroup_tags
=== CONT  TestAccAutoScalingGroupTag_disappears
=== CONT  TestAccAutoScalingGroupTag_value
=== CONT  TestAccAutoScalingGroupTag_basic
--- PASS: TestAccAutoScalingGroupTag_disappears (42.11s)
--- PASS: TestAccAutoScalingGroupTag_basic (70.47s)
--- PASS: TestAccAutoScalingGroupTag_value (91.87s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (171.50s)
--- PASS: TestAccAutoScalingGroup_tags (220.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	227.410s

@anGie44 anGie44 added this to the v3.64.0 milestone Oct 19, 2021
@anGie44 anGie44 merged commit fe61d69 into main Oct 19, 2021
@anGie44 anGie44 deleted the b-asg-tag-gen branch October 19, 2021 14:01
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants