Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention PKG_NAME in contributing docs #21463

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Mention PKG_NAME in contributing docs #21463

merged 1 commit into from
Oct 25, 2021

Conversation

wedge-jarrad
Copy link
Contributor

After the refactor in #21306 running acceptance tests gets ugly if you don't
specify the package with the PKG_NAME parameter. Update examples to show this
in action.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@wedge-jarrad
Mention PKG_NAME in contributing docs
9e1be6f 
After the refactor in hashicorp#21306 running acceptance tests gets ugly if you don't
specify the package with the PKG_NAME parameter. Update examples to show this
in action.
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Oct 24, 2021
@justinretzolk
Copy link
Member

Thank you for your contribution @wedge-jarrad! Looks good to me! 🚀

@justinretzolk justinretzolk merged commit a789337 into hashicorp:main Oct 25, 2021
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 25, 2021
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 25, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wedge-jarrad @justinretzolk