Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoints assignment, testing #21641

Merged
merged 5 commits into from
Nov 5, 2021
Merged

Fix endpoints assignment, testing #21641

merged 5 commits into from
Nov 5, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Nov 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21639
Relates #21637
Fixes #21437
Fixes #20823

Output from acceptance testing (us-west-2):

--- PASS: TestTlsRsaPrivateKeyPem (0.15s)
--- PASS: TestTlsRsaPublicKeyPem (0.13s)
--- PASS: TestTlsRsaX509LocallySignedCertificatePem (0.15s)
--- PASS: TestTlsRsaX509SelfSignedCaCertificatePem (0.20s)
--- PASS: TestTlsRsaX509SelfSignedCertificatePem (0.15s)
--- PASS: TestTlsRsaX509CertificateRequestPem (0.14s)
--- PASS: TestAccAcctestProvider_Region_awsCommercial (19.35s)
--- PASS: TestAccAcctestProvider_Region_awsC2S (20.18s)
--- PASS: TestAccAcctestProvider_Region_awsChina (20.59s)
--- PASS: TestAccAcctestProvider_Region_awsSC2S (22.79s)
--- PASS: TestAccAcctestProvider_Region_awsGovCloudUs (22.92s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_multiple (24.78s)
--- PASS: TestAccAcctestProvider_IgnoreTags_emptyBlock (24.79s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_none (24.81s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_multiple (25.07s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none (25.25s)
--- PASS: TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks (25.27s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_none (25.28s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_one (25.29s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one (25.29s)
--- PASS: TestAccAcctestProvider_DefaultTags_emptyBlock (25.36s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple (25.38s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_one (26.13s)
--- PASS: TestAccAcctestProvider_endpoints (26.50s)
--- PASS: TestAccAcctestProvider_AssumeRole_empty (26.69s)
--- PASS: TestAccAcctestProvider_fipsEndpoint (37.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	39.991s

Output from acceptance testing (GovCloud):

--- PASS: TestTlsRsaPrivateKeyPem (0.34s)
--- PASS: TestTlsRsaPublicKeyPem (0.09s)
--- PASS: TestTlsRsaX509LocallySignedCertificatePem (0.42s)
--- PASS: TestTlsRsaX509SelfSignedCaCertificatePem (0.09s)
--- PASS: TestTlsRsaX509SelfSignedCertificatePem (0.06s)
--- PASS: TestTlsRsaX509CertificateRequestPem (0.16s)
--- PASS: TestAccAcctestProvider_Region_awsChina (20.18s)
--- PASS: TestAccAcctestProvider_Region_awsCommercial (20.24s)
--- PASS: TestAccAcctestProvider_Region_awsC2S (20.40s)
--- PASS: TestAccAcctestProvider_Region_awsGovCloudUs (20.66s)
--- PASS: TestAccAcctestProvider_Region_awsSC2S (21.37s)
--- PASS: TestAccAcctestProvider_DefaultTags_emptyBlock (25.26s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple (25.34s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_multiple (25.43s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_one (25.52s)
--- PASS: TestAccAcctestProvider_IgnoreTags_emptyBlock (25.58s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_none (25.69s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_multiple (25.70s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none (25.70s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_one (25.76s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one (25.76s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_none (25.76s)
--- PASS: TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks (25.77s)
--- PASS: TestAccAcctestProvider_endpoints (26.11s)
--- PASS: TestAccAcctestProvider_AssumeRole_empty (29.51s)
--- PASS: TestAccAcctestProvider_fipsEndpoint (39.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	42.390s

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Nov 4, 2021
@YakDriver YakDriver added this to the v3.64.1 milestone Nov 4, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 4, 2021
@YakDriver YakDriver merged commit 755f396 into main Nov 5, 2021
@YakDriver YakDriver deleted the b-endpoints-point branch November 5, 2021 00:01
@github-actions github-actions bot modified the milestones: v3.64.1, v3.65.0 Nov 5, 2021
@YakDriver YakDriver modified the milestones: v3.65.0, v3.64.1 Nov 5, 2021
github-actions bot pushed a commit that referenced this pull request Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This functionality has been released in v3.64.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAccNASAcctest_Provider_endpoints failing with error Non-existent custom service endpoint definitions?
1 participant