Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ebs_encryption_by_default - add import support #21717

Merged

Conversation

kamilturek
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21699.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccEC2EBSEncryptionByDefault_basic" PKG_NAME="internal/service/ec2"                                                                                                                                           4s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2EBSEncryptionByDefault_basic -timeout 180m
=== RUN   TestAccEC2EBSEncryptionByDefault_basic
=== PAUSE TestAccEC2EBSEncryptionByDefault_basic
=== CONT  TestAccEC2EBSEncryptionByDefault_basic
--- PASS: TestAccEC2EBSEncryptionByDefault_basic (43.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        51.769s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Nov 10, 2021
@kamilturek kamilturek marked this pull request as ready for review November 10, 2021 23:07
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 11, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS="-run=TestAccEC2EBSEncryptionByDefault_basic" PKG_NAME="internal/service/ec2"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2EBSEncryptionByDefault_basic -timeout 180m
=== RUN   TestAccEC2EBSEncryptionByDefault_basic
=== PAUSE TestAccEC2EBSEncryptionByDefault_basic
=== CONT  TestAccEC2EBSEncryptionByDefault_basic
--- PASS: TestAccEC2EBSEncryptionByDefault_basic (23.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.220s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0983591 into hashicorp:main Nov 11, 2021
@kamilturek kamilturek deleted the f-aws_ebs_encryption_by_default_importer branch November 11, 2021 13:56
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 11, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource "aws_ebs_encryption_by_default" doesn't support import
2 participants