-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for SQS-managed SSE #21954
Conversation
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
What will happen if |
If they are both set, received: |
ebf7808
to
0214d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccSQSQueue_ PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20 -run='TestAccSQSQueue_' -timeout 180m
=== RUN TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN TestAccSQSQueue_disappears
=== PAUSE TestAccSQSQueue_disappears
=== RUN TestAccSQSQueue_Name_generated
=== PAUSE TestAccSQSQueue_Name_generated
=== RUN TestAccSQSQueue_NameGenerated_fifoQueue
=== PAUSE TestAccSQSQueue_NameGenerated_fifoQueue
=== RUN TestAccSQSQueue_namePrefix
=== PAUSE TestAccSQSQueue_namePrefix
=== RUN TestAccSQSQueue_NamePrefix_fifoQueue
=== PAUSE TestAccSQSQueue_NamePrefix_fifoQueue
=== RUN TestAccSQSQueue_tags
=== PAUSE TestAccSQSQueue_tags
=== RUN TestAccSQSQueue_update
=== PAUSE TestAccSQSQueue_update
=== RUN TestAccSQSQueue_policy
=== PAUSE TestAccSQSQueue_policy
=== RUN TestAccSQSQueue_recentlyDeleted
=== PAUSE TestAccSQSQueue_recentlyDeleted
=== RUN TestAccSQSQueue_redrivePolicy
=== PAUSE TestAccSQSQueue_redrivePolicy
=== RUN TestAccSQSQueue_fifoQueue
=== PAUSE TestAccSQSQueue_fifoQueue
=== RUN TestAccSQSQueue_FIFOQueue_expectNameError
=== PAUSE TestAccSQSQueue_FIFOQueue_expectNameError
=== RUN TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== PAUSE TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== RUN TestAccSQSQueue_FIFOQueue_highThroughputMode
=== PAUSE TestAccSQSQueue_FIFOQueue_highThroughputMode
=== RUN TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== PAUSE TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== RUN TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN TestAccSQSQueue_zeroVisibilityTimeoutSeconds
=== PAUSE TestAccSQSQueue_zeroVisibilityTimeoutSeconds
=== RUN TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== PAUSE TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== CONT TestAccSQSQueue_basic
=== CONT TestAccSQSQueue_redrivePolicy
=== CONT TestAccSQSQueue_NamePrefix_fifoQueue
=== CONT TestAccSQSQueue_Name_generated
=== CONT TestAccSQSQueue_namePrefix
=== CONT TestAccSQSQueue_tags
=== CONT TestAccSQSQueue_disappears
=== CONT TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds
=== CONT TestAccSQSQueue_zeroVisibilityTimeoutSeconds
=== CONT TestAccSQSQueue_encryption
=== CONT TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError
=== CONT TestAccSQSQueue_FIFOQueue_highThroughputMode
=== CONT TestAccSQSQueue_FIFOQueue_contentBasedDeduplication
=== CONT TestAccSQSQueue_FIFOQueue_expectNameError
=== CONT TestAccSQSQueue_NameGenerated_fifoQueue
=== CONT TestAccSQSQueue_fifoQueue
=== CONT TestAccSQSQueue_policy
=== CONT TestAccSQSQueue_recentlyDeleted
=== CONT TestAccSQSQueue_update
--- PASS: TestAccSQSQueue_StandardQueue_expectContentBasedDeduplicationError (7.27s)
--- PASS: TestAccSQSQueue_FIFOQueue_expectNameError (7.88s)
--- PASS: TestAccSQSQueue_disappears (30.97s)
--- PASS: TestAccSQSQueue_basic (42.31s)
--- PASS: TestAccSQSQueue_zeroVisibilityTimeoutSeconds (42.70s)
--- PASS: TestAccSQSQueue_namePrefix (42.87s)
--- PASS: TestAccSQSQueue_defaultKMSDataKeyReusePeriodSeconds (43.04s)
--- PASS: TestAccSQSQueue_NameGenerated_fifoQueue (43.04s)
--- PASS: TestAccSQSQueue_Name_generated (43.04s)
--- PASS: TestAccSQSQueue_fifoQueue (43.25s)
--- PASS: TestAccSQSQueue_NamePrefix_fifoQueue (43.35s)
--- PASS: TestAccSQSQueue_FIFOQueue_contentBasedDeduplication (43.35s)
--- PASS: TestAccSQSQueue_redrivePolicy (45.12s)
--- PASS: TestAccSQSQueue_FIFOQueue_highThroughputMode (55.73s)
--- PASS: TestAccSQSQueue_update (56.09s)
--- PASS: TestAccSQSQueue_tags (64.29s)
--- PASS: TestAccSQSQueue_encryption (66.22s)
--- PASS: TestAccSQSQueue_policy (80.43s)
--- PASS: TestAccSQSQueue_recentlyDeleted (88.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sqs 92.055s
@rmorris1218 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21948 -- add support for SSE-SQS for the
aws_sqs_queue
resource.Output from acceptance testing: