Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestream actions in IoT Rules #22337

Closed

Conversation

thiagoarrais
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

This PR adds support for Timestream actions in IoT rules. Both for main output and as error actions.

Closes #19904

Output from acceptance testing:

$ make testacc TESTS=TestAccIoTTopicRule PKG=iot            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTTopicRule' -timeout 180m
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_cloudWatchAlarm
=== PAUSE TestAccIoTTopicRule_cloudWatchAlarm
=== RUN   TestAccIoTTopicRule_cloudWatchMetric
=== PAUSE TestAccIoTTopicRule_cloudWatchMetric
=== RUN   TestAccIoTTopicRule_dynamoDB
=== PAUSE TestAccIoTTopicRule_dynamoDB
=== RUN   TestAccIoTTopicRule_dynamoDBv2
=== PAUSE TestAccIoTTopicRule_dynamoDBv2
=== RUN   TestAccIoTTopicRule_elasticSearch
=== PAUSE TestAccIoTTopicRule_elasticSearch
=== RUN   TestAccIoTTopicRule_firehose
=== PAUSE TestAccIoTTopicRule_firehose
=== RUN   TestAccIoTTopicRule_Firehose_separator
=== PAUSE TestAccIoTTopicRule_Firehose_separator
=== RUN   TestAccIoTTopicRule_kinesis
=== PAUSE TestAccIoTTopicRule_kinesis
=== RUN   TestAccIoTTopicRule_lambda
=== PAUSE TestAccIoTTopicRule_lambda
=== RUN   TestAccIoTTopicRule_republish
=== PAUSE TestAccIoTTopicRule_republish
=== RUN   TestAccIoTTopicRule_republishWithQos
=== PAUSE TestAccIoTTopicRule_republishWithQos
=== RUN   TestAccIoTTopicRule_s3
=== PAUSE TestAccIoTTopicRule_s3
=== RUN   TestAccIoTTopicRule_sns
=== PAUSE TestAccIoTTopicRule_sns
=== RUN   TestAccIoTTopicRule_sqs
=== PAUSE TestAccIoTTopicRule_sqs
=== RUN   TestAccIoTTopicRule_Step_functions
=== PAUSE TestAccIoTTopicRule_Step_functions
=== RUN   TestAccIoTTopicRule_Timestream
=== PAUSE TestAccIoTTopicRule_Timestream
=== RUN   TestAccIoTTopicRule_IoT_analytics
=== PAUSE TestAccIoTTopicRule_IoT_analytics
=== RUN   TestAccIoTTopicRule_IoT_events
=== PAUSE TestAccIoTTopicRule_IoT_events
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== RUN   TestAccIoTTopicRule_errorAction
=== PAUSE TestAccIoTTopicRule_errorAction
=== RUN   TestAccIoTTopicRule_updateKinesisErrorAction
=== PAUSE TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_basic
=== CONT  TestAccIoTTopicRule_republishWithQos
=== CONT  TestAccIoTTopicRule_updateKinesisErrorAction
=== CONT  TestAccIoTTopicRule_errorAction
=== CONT  TestAccIoTTopicRule_tags
=== CONT  TestAccIoTTopicRule_IoT_events
=== CONT  TestAccIoTTopicRule_IoT_analytics
=== CONT  TestAccIoTTopicRule_Timestream
=== CONT  TestAccIoTTopicRule_Step_functions
=== CONT  TestAccIoTTopicRule_sqs
=== CONT  TestAccIoTTopicRule_sns
=== CONT  TestAccIoTTopicRule_s3
=== CONT  TestAccIoTTopicRule_firehose
=== CONT  TestAccIoTTopicRule_republish
=== CONT  TestAccIoTTopicRule_lambda
=== CONT  TestAccIoTTopicRule_kinesis
=== CONT  TestAccIoTTopicRule_Firehose_separator
=== CONT  TestAccIoTTopicRule_dynamoDB
=== CONT  TestAccIoTTopicRule_elasticSearch
=== CONT  TestAccIoTTopicRule_dynamoDBv2
--- PASS: TestAccIoTTopicRule_basic (37.89s)
=== CONT  TestAccIoTTopicRule_cloudWatchMetric
--- PASS: TestAccIoTTopicRule_lambda (50.21s)
=== CONT  TestAccIoTTopicRule_cloudWatchAlarm
--- PASS: TestAccIoTTopicRule_IoT_analytics (54.03s)
--- PASS: TestAccIoTTopicRule_sqs (63.18s)
--- PASS: TestAccIoTTopicRule_firehose (63.26s)
--- PASS: TestAccIoTTopicRule_errorAction (63.27s)
--- PASS: TestAccIoTTopicRule_republish (64.01s)
--- PASS: TestAccIoTTopicRule_dynamoDBv2 (68.44s)
--- PASS: TestAccIoTTopicRule_IoT_events (68.47s)
--- PASS: TestAccIoTTopicRule_republishWithQos (73.77s)
--- PASS: TestAccIoTTopicRule_Step_functions (73.97s)
--- PASS: TestAccIoTTopicRule_elasticSearch (73.99s)
--- PASS: TestAccIoTTopicRule_Timestream (74.00s)
--- PASS: TestAccIoTTopicRule_s3 (74.10s)
--- PASS: TestAccIoTTopicRule_kinesis (74.20s)
--- PASS: TestAccIoTTopicRule_sns (74.61s)
--- PASS: TestAccIoTTopicRule_cloudWatchMetric (45.85s)
--- PASS: TestAccIoTTopicRule_Firehose_separator (92.01s)
--- PASS: TestAccIoTTopicRule_tags (94.13s)
--- PASS: TestAccIoTTopicRule_updateKinesisErrorAction (104.55s)
--- PASS: TestAccIoTTopicRule_dynamoDB (105.84s)
--- PASS: TestAccIoTTopicRule_cloudWatchAlarm (55.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        106.034s

@github-actions github-actions bot added service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Dec 23, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @thiagoarrais 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Dec 23, 2021
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2022
@thiagoarrais thiagoarrais force-pushed the timestream-iot-action branch from cb03da2 to 73b554a Compare February 9, 2022 15:03
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 9, 2022
@thiagoarrais thiagoarrais force-pushed the timestream-iot-action branch from 2e114f9 to 6f0e727 Compare March 7, 2022 13:09
ewbankkit added a commit to jalavoy/terraform-provider-aws that referenced this pull request May 5, 2022
@ewbankkit
Copy link
Contributor

@thiagoarrais Thanks for the contribution 🎉 👏.
This work has been rolled into #24395.

@ewbankkit ewbankkit closed this May 5, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing timestream action in aws_iot_topic_rule
3 participants