Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/ec2_client_vpn_endpoint: fix dns_servers docs #22367

Merged

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Dec 29, 2021

The docs for the dns_servers argument of the
aws_ec2_client_vpn_endpoint resource is erroneous. When not specified,
the Client VPN does not automatically use the VPC DNS address. This can
be verified by checking the AWS API docs:

If no DNS server is specified, the DNS address configured on the
device is used for the DNS server.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. labels Dec 29, 2021
@jalaziz jalaziz force-pushed the d-fix-client-vpn-endpoint-docs branch from 0b7abc2 to 3bf34c4 Compare December 29, 2021 06:19
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 29, 2021

Verified

This commit was signed with the committer’s verified signature.
jalaziz Jameel Al-Aziz
The docs for the `dns_servers` argument of the
`aws_ec2_client_vpn_endpoint` resource is erroneous. When not specified,
the Client VPN does not automatically use the VPC DNS address. This can
be verified by checking the [AWS API docs][1]:

> If no DNS server is specified, the DNS address configured on the
> device is used for the DNS server.

[1]: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateClientVpnEndpoint.html
@jalaziz jalaziz force-pushed the d-fix-client-vpn-endpoint-docs branch from 3bf34c4 to 5e4c347 Compare December 29, 2021 06:20
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @jalaziz!

@breathingdust breathingdust merged commit 21e5c25 into hashicorp:main Jan 12, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 12, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants