Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_source: ap-southeast-3 (Jakarta) #22453

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Jan 7, 2022

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-access-logs.html#access-logging-bucket-permissions

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22252, #22295

prev: #12967, #13061, fixed doc links in #22294

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. labels Jan 7, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccELBServiceAccountDataSource_ PKG=elb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBServiceAccountDataSource_' -timeout 180m
=== RUN   TestAccELBServiceAccountDataSource_basic
=== PAUSE TestAccELBServiceAccountDataSource_basic
=== RUN   TestAccELBServiceAccountDataSource_region
=== PAUSE TestAccELBServiceAccountDataSource_region
=== CONT  TestAccELBServiceAccountDataSource_basic
=== CONT  TestAccELBServiceAccountDataSource_region
--- PASS: TestAccELBServiceAccountDataSource_basic (9.06s)
--- PASS: TestAccELBServiceAccountDataSource_region (9.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	13.163s

@ewbankkit
Copy link
Contributor

@PatMyron Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3a075c2 into hashicorp:main Jan 7, 2022
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 7, 2022
@PatMyron PatMyron deleted the patch-1 branch January 7, 2022 14:42
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Jan 21, 2022
prev: hashicorp/terraform-provider-aws#22453, #18110

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
prev: hashicorp/terraform-provider-aws#22453, aws#18110

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants