Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely state that updates to instance_type field will trigger a stop/start of the EC2 instance #2250

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Nov 10, 2017

No description provided.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it'd be nice if Terraform core supported denoting resource restarts/downtime like this in plan at a higher level, similar to how it denotes (forces new resource)

@pdecat
Copy link
Contributor Author

pdecat commented Nov 10, 2017

Thanks @bflad!

+1 for adding a mean to warn about restarts/downtime in plans!

Edit: digging into the existing issues to see if its already there...

@radeksimko radeksimko added documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. labels Nov 10, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bflad Totally agreed, the current behaviour is not ideal at all and is kind of breaking the promise of Terraform that apply will do what plan suggests.

We did discuss some improvements in the schema a while ago. I'm don't think there's a specific issue in core repo yet - so feel free to create one and we can all chime in with ideas.

@radeksimko radeksimko merged commit 04b31ad into hashicorp:master Nov 15, 2017
@radeksimko radeksimko added the upstream-terraform Addresses functionality related to the Terraform core binary. label Nov 15, 2017
@pdecat
Copy link
Contributor Author

pdecat commented Nov 15, 2017

@radeksimko I already created the issue https://github.com/hashicorp/terraform/issues/16624 last week.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. upstream-terraform Addresses functionality related to the Terraform core binary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants