Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket: read-only policy argument #22538

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccELBLoadBalancerDataSource_basic (162.45s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (229.81s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (71.85s)
--- PASS: TestAccELBLoadBalancer_ListenerSSLCertificateID_iamServerCertificate (246.75s)
--- PASS: TestAccELBLoadBalancer_Swap_subnets (185.75s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (186.23s)
--- PASS: TestAccELBLoadBalancer_basic (155.22s)
--- PASS: TestAccELBLoadBalancer_connectionDraining (179.82s)
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode (92.31s)
--- PASS: TestAccELBLoadBalancer_desyncMitigationMode_update (170.63s)
--- PASS: TestAccELBLoadBalancer_disappears (266.08s)
--- PASS: TestAccELBLoadBalancer_fullCharacterRange (103.78s)
--- PASS: TestAccELBLoadBalancer_generatedName (111.45s)
--- PASS: TestAccELBLoadBalancer_generatesNameForZeroValue (244.88s)
--- PASS: TestAccELBLoadBalancer_healthCheck (120.99s)
--- PASS: TestAccELBLoadBalancer_instanceAttaching (200.23s)
--- PASS: TestAccELBLoadBalancer_listener (130.65s)
--- PASS: TestAccELBLoadBalancer_namePrefix (49.09s)
--- PASS: TestAccELBLoadBalancer_securityGroups (198.96s)
--- PASS: TestAccELBLoadBalancer_tags (176.68s)
--- PASS: TestAccELBLoadBalancer_timeout (156.86s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (15.14s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (168.28s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (166.07s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (170.10s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (166.91s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (167.67s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (102.36s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (14.79s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (100.66s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (98.93s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (153.95s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (241.90s)
--- PASS: TestAccS3BucketDataSource_basic (87.18s)
--- PASS: TestAccS3BucketDataSource_website (88.95s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (379.52s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (101.77s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (85.80s)
--- PASS: TestAccS3BucketInventory_basic (101.76s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (101.14s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (98.38s)
--- PASS: TestAccS3BucketMetric_basic (100.06s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (15.64s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (167.85s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (168.74s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (166.63s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (166.00s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (165.62s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (115.21s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (101.46s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (127.08s)
--- PASS: TestAccS3BucketNotification_queue (126.72s)
--- PASS: TestAccS3BucketNotification_topic (100.37s)
--- PASS: TestAccS3BucketNotification_update (183.60s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (89.14s)
--- PASS: TestAccS3BucketObjectDataSource_basic (86.89s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (88.97s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (89.49s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (86.90s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (159.43s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (155.70s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (87.01s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (85.76s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (87.57s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (84.51s)
--- PASS: TestAccS3BucketObject_acl (247.49s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (91.31s)
--- PASS: TestAccS3BucketObject_content (102.28s)
--- PASS: TestAccS3BucketObject_contentBase64 (87.53s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (88.63s)
--- PASS: TestAccS3BucketObject_empty (100.05s)
--- PASS: TestAccS3BucketObject_etagEncryption (102.00s)
--- PASS: TestAccS3BucketObject_ignoreTags (165.10s)
--- PASS: TestAccS3BucketObject_kms (102.89s)
--- PASS: TestAccS3BucketObject_metadata (248.70s)
--- PASS: TestAccS3BucketObject_noNameNoKey (23.23s)
--- PASS: TestAccS3BucketObject_nonVersioned (101.27s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (90.12s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (237.67s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (158.55s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (235.73s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (301.36s)
--- PASS: TestAccS3BucketObject_source (99.29s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (174.97s)
--- PASS: TestAccS3BucketObject_sse (101.43s)
--- PASS: TestAccS3BucketObject_storageClass (390.54s)
--- PASS: TestAccS3BucketObject_tags (316.90s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (309.55s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (320.73s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (307.43s)
--- PASS: TestAccS3BucketObject_updateSameFile (162.11s)
--- PASS: TestAccS3BucketObject_updates (175.38s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (173.83s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (165.17s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (88.55s)
--- PASS: TestAccS3BucketObjectsDataSource_all (168.04s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (168.87s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (164.05s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (164.86s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (166.73s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (164.74s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (166.20s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (165.09s)
--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (81.39s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (181.22s)
--- PASS: TestAccS3BucketOwnershipControls_basic (105.59s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (89.89s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (364.47s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (274.46s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (290.29s)
--- PASS: TestAccS3BucketPolicy_basic (100.14s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (182.83s)
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (77.96s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (102.16s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (252.47s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (250.34s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (87.51s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (250.51s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (247.26s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (541.10s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (493.25s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (479.91s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (141.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (358.11s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (359.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (408.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (406.22s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (402.71s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (403.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (396.39s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (365.66s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (237.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (407.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (311.74s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (402.11s)
--- PASS: TestAccS3BucketVersioning_MFADelete (65.24s)
--- PASS: TestAccS3BucketVersioning_basic (96.92s)
--- PASS: TestAccS3BucketVersioning_disappears (89.75s)
--- PASS: TestAccS3BucketVersioning_update (147.20s)
--- PASS: TestAccS3Bucket_Basic_acceleration (64.31s)
--- PASS: TestAccS3Bucket_Basic_basic (57.70s)
--- PASS: TestAccS3Bucket_Basic_emptyString (58.06s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (93.90s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (95.49s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (91.01s)
--- PASS: TestAccS3Bucket_Basic_generatedName (38.97s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (57.16s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (37.97s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (61.42s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (47.34s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (68.57s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (219.31s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (169.66s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (100.07s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (83.02s)
--- PASS: TestAccS3Bucket_Manage_objectLock (152.72s)
--- PASS: TestAccS3Bucket_Manage_versioning (150.60s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (70.04s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (66.08s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (261.23s)
--- PASS: TestAccS3Bucket_Replication_basic (294.07s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (75.54s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (166.14s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (164.38s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (221.56s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (218.53s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (299.15s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (111.91s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (165.99s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (156.91s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (157.88s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (54.48s)
--- PASS: TestAccS3Bucket_Security_corsDelete (65.36s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (77.44s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (148.50s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (102.27s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (53.55s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (52.16s)
--- PASS: TestAccS3Bucket_Security_grantToACL (71.79s)
--- PASS: TestAccS3Bucket_Security_logging (83.91s)
--- PASS: TestAccS3Bucket_Security_updateACL (59.89s)
--- PASS: TestAccS3Bucket_Security_updateGrant (100.46s)
--- PASS: TestAccS3Bucket_Tags_basic (37.46s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (57.71s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (135.65s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (167.82s)
--- PASS: TestAccS3Bucket_Web_redirect (151.87s)
--- PASS: TestAccS3Bucket_Web_routingRules (96.96s)
--- PASS: TestAccS3Bucket_Web_simple (156.53s)
--- PASS: TestBucketName (0.04s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestLoadBalancerListenerHash (0.00s)
--- PASS: TestValidLoadBalancerAccessLogsInterval (0.00s)
--- PASS: TestValidLoadBalancerHealthCheckTarget (0.00s)
--- PASS: TestValidLoadBalancerNameCanBeAnEmptyString (0.00s)
--- PASS: TestValidLoadBalancerNameCannotBeLongerThan32Characters (0.00s)
--- PASS: TestValidLoadBalancerNameCannotBeginWithHyphen (0.00s)
--- PASS: TestValidLoadBalancerNameCannotEndWithHyphen (0.00s)
--- PASS: TestValidLoadBalancerNameCannotHaveSpecialCharacters (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jan 12, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Jan 12, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from 48d05bd to 48036c6 Compare January 12, 2022 03:07
@anGie44 anGie44 changed the base branch from main to release/4.x January 13, 2022 22:45
@anGie44 anGie44 changed the title r/s3_bucket: deprecate policy argument r/s3_bucket: read-only policy argument Jan 14, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from ec033d5 to 74718f5 Compare January 14, 2022 21:11
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 14, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch 2 times, most recently from a8b70fb to defccff Compare January 14, 2022 22:48
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 14, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from defccff to e48aad9 Compare January 26, 2022 22:54
@github-actions github-actions bot added service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/meta service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jan 26, 2022
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 02:01
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from 5448d20 to 80ba913 Compare January 27, 2022 06:29
@github-actions github-actions bot removed the size/XL Managed by automation to categorize the size of a PR. label Jan 27, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch 3 times, most recently from 4ab6af9 to 947a47a Compare February 6, 2022 20:31
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 6, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from 947a47a to f8f3856 Compare February 7, 2022 01:28
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from d1b48d6 to 8fca540 Compare February 7, 2022 01:51
@anGie44 anGie44 force-pushed the f-s3-bucket-policy-deprecation branch from 8fca540 to dfbac43 Compare February 7, 2022 01:56
@anGie44 anGie44 merged commit ad693b9 into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-policy-deprecation branch February 7, 2022 02:28
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jdobyns
This comment was marked as a violation of GitHub Acceptable Use Policies
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants