Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only lifecycle_rule #22581

Merged
merged 7 commits into from
Feb 7, 2022
Merged

r/s3_bucket: read-only lifecycle_rule #22581

merged 7 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 13, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433
Preceded by #22579

Output from acceptance testing:

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (15.65s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (168.62s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (166.32s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (167.13s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (167.17s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (162.74s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (99.85s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (15.10s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (102.10s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (98.14s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (153.88s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (239.59s)

--- PASS: TestAccS3BucketDataSource_basic (88.93s)
--- PASS: TestAccS3BucketDataSource_website (88.09s)

--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (377.37s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (101.76s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (88.85s)

--- PASS: TestAccS3BucketInventory_basic (100.33s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (101.28s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (101.35s)

--- PASS: TestAccS3BucketMetric_basic (98.88s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (15.35s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (165.32s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (165.94s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (163.19s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (165.50s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (164.80s)

--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (116.91s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (98.15s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (113.98s)
--- PASS: TestAccS3BucketNotification_queue (127.69s)
--- PASS: TestAccS3BucketNotification_topic (95.63s)
--- PASS: TestAccS3BucketNotification_update (184.13s)

--- PASS: TestAccS3BucketObjectDataSource_allParams (87.60s)
--- PASS: TestAccS3BucketObjectDataSource_basic (85.74s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (88.26s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (87.78s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (90.37s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (157.57s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (156.61s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (90.07s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (87.07s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (88.51s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (90.12s)

--- PASS: TestAccS3BucketObject_acl (246.36s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (93.38s)
--- PASS: TestAccS3BucketObject_content (99.42s)
--- PASS: TestAccS3BucketObject_contentBase64 (84.62s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (90.66s)
--- PASS: TestAccS3BucketObject_empty (99.30s)
--- PASS: TestAccS3BucketObject_etagEncryption (99.50s)
--- PASS: TestAccS3BucketObject_ignoreTags (164.80s)
--- PASS: TestAccS3BucketObject_kms (97.99s)
--- PASS: TestAccS3BucketObject_metadata (246.05s)
--- PASS: TestAccS3BucketObject_noNameNoKey (24.90s)
--- PASS: TestAccS3BucketObject_nonVersioned (101.85s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (87.64s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (237.62s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (163.32s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (237.10s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (307.69s)
--- PASS: TestAccS3BucketObject_source (101.45s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (171.46s)
--- PASS: TestAccS3BucketObject_sse (97.51s)
--- PASS: TestAccS3BucketObject_storageClass (391.02s)
--- PASS: TestAccS3BucketObject_tags (316.36s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (301.57s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (318.91s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (304.75s)
--- PASS: TestAccS3BucketObject_updateSameFile (154.58s)
--- PASS: TestAccS3BucketObject_updates (169.27s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (172.99s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (157.89s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (87.32s)

--- PASS: TestAccS3BucketObjectsDataSource_all (164.30s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (166.64s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (166.25s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (167.38s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (163.55s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (166.29s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (169.57s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (166.61s)

--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (75.80s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (178.77s)
--- PASS: TestAccS3BucketOwnershipControls_basic (100.51s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (88.61s)

--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (362.27s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (267.96s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (292.41s)
--- PASS: TestAccS3BucketPolicy_basic (101.84s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (184.97s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (75.88s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (103.28s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (249.39s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (248.72s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (89.40s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (247.24s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (247.18s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (539.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (484.66s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (476.69s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (139.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (364.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (359.41s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (404.41s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (403.69s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (397.98s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (398.00s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (392.17s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (363.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (233.00s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (402.22s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (317.89s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (397.96s)

--- PASS: TestAccS3BucketVersioning_MFADelete (84.95s)
--- PASS: TestAccS3BucketVersioning_basic (101.37s)
--- PASS: TestAccS3BucketVersioning_disappears (92.14s)
--- PASS: TestAccS3BucketVersioning_update (140.06s)

--- PASS: TestAccS3Bucket_Basic_acceleration (65.29s)
--- PASS: TestAccS3Bucket_Basic_basic (59.15s)
--- PASS: TestAccS3Bucket_Basic_emptyString (57.98s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (93.33s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (92.07s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (92.33s)
--- PASS: TestAccS3Bucket_Basic_generatedName (37.15s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (68.04s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (38.03s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (56.32s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (48.91s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (73.67s)
--- PASS: TestAccS3Bucket_Manage_objectLock (144.42s)
--- PASS: TestAccS3Bucket_Manage_versioning (156.96s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (77.76s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (69.91s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (256.48s)
--- PASS: TestAccS3Bucket_Replication_basic (291.00s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (74.36s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (156.60s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (160.41s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (213.57s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (207.65s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (290.89s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (109.24s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (161.41s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (150.07s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (154.98s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (71.63s)
--- PASS: TestAccS3Bucket_Security_corsDelete (64.91s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (86.78s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (148.27s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (140.37s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (55.58s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (54.70s)
--- PASS: TestAccS3Bucket_Security_grantToACL (85.62s)
--- PASS: TestAccS3Bucket_Security_logging (92.90s)
--- PASS: TestAccS3Bucket_Security_policy (98.20s)
--- PASS: TestAccS3Bucket_Security_updateACL (58.75s)
--- PASS: TestAccS3Bucket_Security_updateGrant (103.54s)
--- PASS: TestAccS3Bucket_Tags_basic (38.60s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (58.63s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (132.46s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (164.20s)
--- PASS: TestAccS3Bucket_Web_redirect (169.86s)
--- PASS: TestAccS3Bucket_Web_routingRules (103.82s)
--- PASS: TestAccS3Bucket_Web_simple (156.23s)

--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tags Pertains to resource tagging. size/M Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 13, 2022 22:57
@anGie44 anGie44 changed the title r/s3_bucket: deprecate lifecycle_rule r/s3_bucket: read-only lifecycle_rule Jan 13, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 61414d9 to 7921c27 Compare January 14, 2022 20:38
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 14, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from ce4d683 to 911a9c2 Compare January 14, 2022 20:43
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 14, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 911a9c2 to a4ed363 Compare January 14, 2022 21:16
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 14, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 26, 2022

Preceded by #22579

@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch 3 times, most recently from 33f7fa5 to 20bc12e Compare January 27, 2022 01:10
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 02:25
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 20bc12e to 09cefdc Compare January 27, 2022 06:10
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22581
45d2c35
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 09cefdc to 45d2c35 Compare January 27, 2022 06:20
anGie44
anGie44 commented Feb 2, 2022
View reviewed changes
.changelog/22581.txt Outdated Show resolved Hide resolved
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022

Needs mention in upgrade guide

@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from d4bde21 to 28d6018 Compare February 3, 2022 18:21
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22581
4217a58
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 28d6018 to 8cd7d25 Compare February 3, 2022 18:22
@gdavison gdavison self-assigned this Feb 3, 2022
@gdavison gdavison mentioned this pull request Feb 4, 2022
Closed
anGie44 added a commit that referenced this pull request Feb 4, 2022
@anGie44
Update CHANGELOG for #22581
85aa41b
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from b2cb2ea to 0785495 Compare February 4, 2022 00:12
gdavison
gdavison approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (119.33s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (120.90s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (121.22s)
--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (130.57s)
--- PASS: TestAccS3BucketVersioning_disappears (132.20s)
--- PASS: TestAccS3BucketVersioning_basic (137.90s)
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (140.34s)
--- PASS: TestAccS3BucketVersioning_MFADelete (141.12s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (142.44s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_RedirectOnly (143.09s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (144.95s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (145.30s)
--- PASS: TestAccS3BucketObjectsDataSource_all (210.71s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (114.19s)
--- PASS: TestAccS3Bucket_Manage_objectLock (236.51s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (242.31s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_MultipleRules (246.56s)
--- PASS: TestAccS3Bucket_Security_corsDelete (127.46s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (149.06s)
--- PASS: TestAccS3Bucket_Security_logging (158.52s)
--- PASS: TestAccS3BucketVersioning_update (349.69s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (242.84s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (242.21s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (105.01s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (144.13s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (142.69s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (247.00s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (147.40s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (250.95s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (254.32s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (405.18s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (146.59s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (248.74s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (142.70s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (146.79s)
--- PASS: TestAccS3Bucket_Manage_versioning (264.37s)
--- PASS: TestAccS3Bucket_Basic_generatedName (134.07s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (402.22s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (404.47s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (233.51s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (144.28s)
--- PASS: TestAccS3Bucket_Security_grantToACL (206.06s)
--- PASS: TestAccS3Bucket_Tags_basic (130.57s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (198.00s)
--- PASS: TestAccS3Bucket_Security_updateACL (208.70s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (204.55s)
--- PASS: TestAccS3Bucket_Basic_acceleration (207.18s)
--- PASS: TestAccS3Bucket_Basic_emptyString (103.13s)
--- PASS: TestAccS3Bucket_Basic_basic (97.43s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyID (104.23s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMSWithMasterKeyArn (97.09s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (195.69s)
--- PASS: TestAccS3Bucket_Security_policy (272.53s)
--- PASS: TestAccS3Bucket_Security_updateGrant (278.51s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_KMS (102.79s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_disappears (89.75s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySEEByDefault_AES256 (103.66s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (679.85s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_basic (110.56s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_Requester (108.99s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_BucketKeyEnabled (194.13s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_BucketKeyEnabled (197.30s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_Basic_BucketOwner (110.82s)
--- PASS: TestAccS3BucketServerSideEncryptionConfiguration_ApplySSEByDefault_UpdateSSEAlgorithm (205.08s)
--- PASS: TestAccS3Bucket_Replication_basic (657.41s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (811.72s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (326.75s)
--- PASS: TestAccS3BucketRequestPaymentConfiguration_update (256.53s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (379.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (102.39s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (234.52s)
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (34.72s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (36.94s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (121.08s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (108.15s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (35.73s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (94.92s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (84.49s)
--- PASS: TestAccS3BucketPolicy_basic (25.88s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (41.90s)
--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (21.27s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (41.77s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (23.42s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (83.93s)
--- PASS: TestAccS3BucketOwnershipControls_basic (25.72s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (388.43s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (83.90s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (44.32s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (391.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (395.90s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (44.72s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (48.61s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (392.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (394.04s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (393.56s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (51.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (396.39s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (58.98s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (61.80s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (170.91s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (374.11s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (378.66s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (376.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (471.04s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (60.21s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (82.63s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (59.24s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (59.80s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (87.31s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (446.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (434.57s)
--- PASS: TestAccS3BucketObject_ignoreTags (121.30s)
--- SKIP: TestAccS3BucketObject_nonVersioned (0.00s)
--- PASS: TestAccS3BucketObject_bucketObjectBucket (139.66s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (118.59s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (399.54s)
--- PASS: TestAccS3BucketObject_sse (93.38s)
--- PASS: TestAccS3BucketObject_kms (93.47s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (89.75s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (198.58s)
--- PASS: TestAccS3BucketObject_contentBase64 (87.76s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (204.30s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (160.38s)
--- PASS: TestAccS3BucketObject_noNameNoKey (19.74s)
--- PASS: TestAccS3BucketObject_etagEncryption (101.02s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (167.19s)
--- PASS: TestAccS3BucketObject_updateSameFile (153.03s)
--- PASS: TestAccS3BucketObject_source (102.38s)
--- PASS: TestAccS3BucketObject_content (105.26s)
--- PASS: TestAccS3BucketObject_updates (166.91s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (257.54s)
--- PASS: TestAccS3BucketObject_metadata (229.86s)
--- PASS: TestAccS3BucketObject_acl (232.13s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (165.00s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (269.00s)
--- PASS: TestAccS3BucketObject_empty (97.11s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (279.50s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (90.47s)
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (94.92s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (90.73s)
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (107.38s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (293.31s)
--- PASS: TestAccS3BucketObject_tags (292.68s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (89.14s)
--- PASS: TestAccS3BucketObjectDataSource_allParams (90.42s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (93.25s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (94.31s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (89.75s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (13.23s)
--- PASS: TestAccS3BucketObjectDataSource_basic (89.09s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (89.88s)
--- PASS: TestAccS3BucketObjectLockConfiguration_update (169.19s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (152.00s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (154.35s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (96.82s)
--- PASS: TestAccS3BucketObject_storageClass (366.48s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (97.33s)
--- PASS: TestAccS3BucketNotification_topic (105.20s)
--- PASS: TestAccS3BucketNotification_eventbridge (96.15s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (114.99s)
--- PASS: TestAccS3BucketNotification_queue (130.85s)
--- PASS: TestAccS3BucketMetric_basic (96.87s)
--- PASS: TestAccS3BucketLogging_disappears (89.76s)
--- PASS: TestAccS3BucketNotification_update (190.98s)
--- PASS: TestAccS3BucketLogging_basic (103.99s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (160.23s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (161.94s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (155.31s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (157.15s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (156.83s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (79.97s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (76.58s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (67.00s)
--- PASS: TestAccS3BucketInventory_basic (78.74s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (73.88s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (220.14s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (218.53s)
--- PASS: TestAccS3BucketLogging_update (220.18s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (215.81s)
--- PASS: TestAccS3BucketDataSource_basic (49.87s)
--- PASS: TestAccS3BucketDataSource_website (50.05s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (56.05s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (54.24s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (8.49s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (218.50s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (219.87s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (47.57s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (9.18s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (218.35s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (55.65s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (213.99s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (61.67s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (198.41s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (286.21s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (199.40s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (277.90s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (98.26s)
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (59.43s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (64.47s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (97.12s)
--- PASS: TestAccS3BucketCorsConfiguration_update (138.25s)
--- PASS: TestAccS3BucketLifecycleConfiguration_FilterWithPrefix (252.65s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (94.86s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (87.37s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (220.19s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (96.61s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (96.46s)
--- PASS: TestAccS3BucketAccelerateConfiguration_update (76.37s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (97.78s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (298.79s)

anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44
Update CHANGELOG for #22581
3e5ff1c
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 4911bb7 to 0f24b97 Compare February 5, 2022 04:23
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 5, 2022

Output of updated acceptance tests:

--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (151.64s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (166.34s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (166.35s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (166.35s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (166.35s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (169.69s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (169.72s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (189.13s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (189.15s)
--- PASS: TestAccS3BucketLifecycleConfiguration_FilterWithPrefix (194.78s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (209.09s)

@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation branch from 0f24b97 to 594a89b Compare February 7, 2022 02:02
@github-actions github-actions bot removed the tags Pertains to resource tagging. label Feb 7, 2022
@anGie44 anGie44 merged commit 27018be into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-lifecycle-rule-deprecation branch February 7, 2022 03:01
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
Update CHANGELOG.md for #22581
6e1cd11
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @gdavison @ewbankkit