New resource for DataPipeline Definition, datasource for DataPipeline Pipeline and Definition

[coderGo93]

• Added a new resource, doc and tests for DataPipeline Definition called aws_datapipeline_definition
• Added a new datasource, doc and tests for DataPipeline Definition called aws_datapipeline_definition
• Added a new datasource, doc and tests for DataPipeline Pipeline called aws_datapipeline_pipeline

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1538

Output from acceptance testing:

Results of Resource DataPipeline Definition

$ make testacc TESTARGS='-run=TestAccDataPipelineDefinition' PKG_NAME=internal/service/datapipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datapipeline/... -v -count 1 -parallel 20  -run=TestAccDataPipelineDefinition -timeout 180m
=== RUN   TestAccDataPipelineDefinitionDataSource_basic
=== PAUSE TestAccDataPipelineDefinitionDataSource_basic
=== RUN   TestAccDataPipelineDefinition_basic
=== PAUSE TestAccDataPipelineDefinition_basic
=== RUN   TestAccDataPipelineDefinition_disappears
=== PAUSE TestAccDataPipelineDefinition_disappears
=== RUN   TestAccDataPipelineDefinition_complete
=== PAUSE TestAccDataPipelineDefinition_complete
=== CONT  TestAccDataPipelineDefinitionDataSource_basic
=== CONT  TestAccDataPipelineDefinition_disappears
=== CONT  TestAccDataPipelineDefinition_complete
=== CONT  TestAccDataPipelineDefinition_basic
--- PASS: TestAccDataPipelineDefinition_disappears (25.12s)
--- PASS: TestAccDataPipelineDefinitionDataSource_basic (25.83s)
--- PASS: TestAccDataPipelineDefinition_basic (30.19s)
--- PASS: TestAccDataPipelineDefinition_complete (179.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       181.967s

Results of DataSource DataPipeline Definition

$ make testacc TESTARGS='-run=TestAccDataPipelineDefinitionDataSource_basic' PKG_NAME=internal/service/datapipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datapipeline/... -v -count 1 -parallel 20  -run=TestAccDataPipelineDefinitionDataSource_basic -timeout 180m
=== RUN   TestAccDataPipelineDefinitionDataSource_basic
=== PAUSE TestAccDataPipelineDefinitionDataSource_basic
=== CONT  TestAccDataPipelineDefinitionDataSource_basic
--- PASS: TestAccDataPipelineDefinitionDataSource_basic (34.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       36.672s

Results of DataSource DataPipeline

$ make testacc TESTARGS='-run=TestAccDataPipelinePipelineDataSource_basic' PKG_NAME=internal/service/datapipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datapipeline/... -v -count 1 -parallel 20  -run=TestAccDataPipelinePipelineDataSource_basic -timeout 180m
=== RUN   TestAccDataPipelinePipelineDataSource_basic
=== PAUSE TestAccDataPipelinePipelineDataSource_basic
=== CONT  TestAccDataPipelinePipelineDataSource_basic
--- PASS: TestAccDataPipelinePipelineDataSource_basic (22.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       24.950s

[zhelding]

All acceptance tests passing on latest PR commit 3b25077

❯ make testacc PKG_NAME=internal/service/datapipeline/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datapipeline//... -v -count 1 -parallel 20   -timeout 180m
--- PASS: TestAccDataPipelinePipeline_disappears (13.43s)
--- PASS: TestAccDataPipelinePipelineDataSource_basic (14.91s)
--- PASS: TestAccDataPipelinePipelineDefinition_disappears (15.01s)
--- PASS: TestAccDataPipelinePipelineDefinitionDataSource_basic (16.47s)
--- PASS: TestAccDataPipelinePipelineDefinition_basic (17.64s)
--- PASS: TestAccDataPipelinePipeline_basic (24.71s)
--- PASS: TestAccDataPipelinePipeline_description (24.92s)
--- PASS: TestAccDataPipelinePipeline_tags (32.73s)
--- PASS: TestAccDataPipelinePipelineDefinition_complete (40.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	40.532s

[zhelding]

Hi @coderGo93! Thank you for the PR.

I've made two notable edits to your contribution:

1. I renamed aws_datapipeline_definition (and all its permutations) to aws_datapipeline_pipeline_definition (or whatever appropriate). This brings the resource name in line with the naming pattern used in the AWS Go SDK datapipeline package.
2. I removed the attribute hashing functions being used as the SchemaSetFunc functions for numerous datapipeline_pipeline_definition attributes -- as well as a number of the ForceNew parameters. Instead: ResourcePipelineDefinition has been given an UpdateContext of resourcePipelineDefinitionPut -- which is equivalent to its CreateContext. As such, any change in the pipeline definition results in it being entirely rewritten / replaced by the API -- as desired.

The remaining edits are then mostly small changes for consistency.

Hoping to have this merged for today's release!

Acceptance tests are passing on latest commit 8148c06.

❯ make testacc PKG_NAME=internal/service/datapipeline/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datapipeline//... -v -count 1 -parallel 20   -timeout 180m
--- PASS: TestAccDataPipelinePipeline_disappears (12.70s)
--- PASS: TestAccDataPipelinePipelineDataSource_basic (14.38s)
--- PASS: TestAccDataPipelinePipelineDefinition_disappears (15.24s)
--- PASS: TestAccDataPipelinePipelineDefinition_basic (16.91s)
--- PASS: TestAccDataPipelinePipelineDefinitionDataSource_basic (17.29s)
--- PASS: TestAccDataPipelinePipeline_basic (24.83s)
--- PASS: TestAccDataPipelinePipeline_description (25.58s)
--- PASS: TestAccDataPipelinePipeline_tags (32.47s)
--- PASS: TestAccDataPipelinePipelineDefinition_complete (41.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       41.701s

[zhelding]

Closes #1538 and #9404

[github-actions]

This functionality has been released in v3.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.