Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only replication_configuration argument #22604

Merged
merged 7 commits into from
Feb 7, 2022
Merged

r/s3_bucket: read-only replication_configuration argument #22604

merged 7 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 15, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3Bucket_Basic_acceleration (166.39s)
--- PASS: TestAccS3Bucket_Basic_basic (95.72s)
--- PASS: TestAccS3Bucket_Basic_emptyString (93.12s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (67.22s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (66.61s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (68.11s)
--- PASS: TestAccS3Bucket_Basic_generatedName (93.91s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (98.63s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (90.60s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (163.97s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (75.13s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (97.13s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (122.38s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (110.39s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (86.29s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (80.26s)
--- PASS: TestAccS3Bucket_Manage_objectLock (86.32s)
--- PASS: TestAccS3Bucket_Manage_versioning (163.71s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (96.76s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (99.69s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (151.16s)
--- PASS: TestAccS3Bucket_Security_corsDelete (83.33s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (92.98s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (119.97s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (159.74s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (95.94s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (97.34s)
--- PASS: TestAccS3Bucket_Security_grantToACL (152.75s)
--- PASS: TestAccS3Bucket_Security_logging (90.93s)
--- PASS: TestAccS3Bucket_Security_policy (232.99s)
--- PASS: TestAccS3Bucket_Security_updateACL (164.05s)
--- PASS: TestAccS3Bucket_Security_updateGrant (233.74s)
--- PASS: TestAccS3Bucket_Tags_basic (97.65s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (152.32s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (268.23s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (286.40s)
--- PASS: TestAccS3Bucket_Web_redirect (226.64s)
--- PASS: TestAccS3Bucket_Web_routingRules (161.05s)
--- PASS: TestAccS3Bucket_Web_simple (232.25s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (416.12s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (407.79s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (407.24s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (114.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (405.35s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (376.71s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (378.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (374.54s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (371.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (376.59s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (376.53s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (375.76s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (219.54s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (378.02s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (377.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (375.53s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 15, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 15, 2022 02:16
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 15, 2022
anGie44 added a commit that referenced this pull request Jan 15, 2022
@anGie44
Update CHANGELOG for #22604
4474ec6
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 marked this pull request as ready for review January 25, 2022 01:29
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 4474ec6 to fea726d Compare January 26, 2022 22:45
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from fea726d to 936e091 Compare January 27, 2022 01:19
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22604
84efbac
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 111cfb9 to 84efbac Compare January 27, 2022 06:36
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from a35637f to a14fa6a Compare January 29, 2022 01:01
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44
Update CHANGELOG for #22604
821cde3
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from a14fa6a to 821cde3 Compare January 29, 2022 01:02
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

% make testacc TESTS=TestAccS3BucketReplicationConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketReplicationConfiguration_'  -timeout 180m
    bucket_replication_configuration_test.go:700: skipping test: AWS Technical Support request required to allow ExistingObjectReplication
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (113.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (205.15s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (361.59s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (362.98s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (363.17s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (363.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (363.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (363.90s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (364.29s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (364.31s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (365.21s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (365.94s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (400.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (404.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (408.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (423.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	426.406s
% make testacc TESTS=TestAccS3Bucket_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_'  -timeout 180m
--- PASS: TestAccS3Bucket_Security_corsUpdate (53.90s)
--- PASS: TestAccS3Bucket_Security_corsDelete (73.85s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (78.54s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (87.11s)
--- PASS: TestAccS3Bucket_Basic_basic (88.40s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (89.28s)
--- PASS: TestAccS3Bucket_Basic_generatedName (89.49s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (90.18s)
--- PASS: TestAccS3Bucket_Tags_basic (91.72s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (109.30s)
--- PASS: TestAccS3Bucket_Security_grantToACL (125.60s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (37.29s)
--- PASS: TestAccS3Bucket_Security_updateACL (125.91s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (63.44s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (63.96s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (137.86s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (59.54s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (140.68s)
--- PASS: TestAccS3Bucket_Web_routingRules (140.89s)
--- PASS: TestAccS3Bucket_Basic_acceleration (141.13s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (52.68s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (52.13s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (60.16s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (61.57s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (31.47s)
--- PASS: TestAccS3Bucket_Security_policy (171.29s)
--- PASS: TestAccS3Bucket_Web_redirect (171.69s)
--- PASS: TestAccS3Bucket_Web_simple (172.08s)
--- PASS: TestAccS3Bucket_Security_updateGrant (172.54s)
--- PASS: TestAccS3Bucket_Basic_emptyString (35.66s)
--- PASS: TestAccS3Bucket_Manage_versioning (92.88s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (42.79s)
--- PASS: TestAccS3Bucket_Manage_objectLock (77.40s)
--- PASS: TestAccS3Bucket_Security_logging (46.06s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (62.75s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (62.79s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (84.97s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (112.25s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (157.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	286.155s

@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 244b425 to 19e6737 Compare February 3, 2022 18:30
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22604
a6ccaa3
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 4699aed to b29908a Compare February 3, 2022 22:51
anGie44 added a commit that referenced this pull request Feb 4, 2022
@anGie44
Update CHANGELOG for #22604
51fc608
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from b29908a to 2494a8d Compare February 4, 2022 16:46
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 4, 2022

Output of acceptance tests after update:

--- PASS: TestAccS3BucketReplicationConfiguration_basic (480.29s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (462.03s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (459.93s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (137.86s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (456.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (397.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (402.79s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (402.54s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (401.91s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (400.58s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (402.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (402.21s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (234.73s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (403.33s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (402.16s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (402.82s)
--- PASS: TestAccS3Bucket_Basic_acceleration (56.17s)
--- PASS: TestAccS3Bucket_Basic_basic (111.74s)
--- PASS: TestAccS3Bucket_Basic_emptyString (113.21s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (23.06s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (21.66s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (18.43s)
--- PASS: TestAccS3Bucket_Basic_generatedName (40.43s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (27.67s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (61.35s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (47.81s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (19.43s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (27.02s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (59.57s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (46.67s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (28.01s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (23.02s)
--- PASS: TestAccS3Bucket_Manage_objectLock (37.50s)
--- PASS: TestAccS3Bucket_Manage_versioning (48.40s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (27.28s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (27.11s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (44.51s)
--- PASS: TestAccS3Bucket_Security_corsDelete (24.39s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (27.21s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (47.03s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (46.97s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (27.76s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (29.18s)
--- PASS: TestAccS3Bucket_Security_grantToACL (44.21s)
--- PASS: TestAccS3Bucket_Security_logging (29.22s)
--- PASS: TestAccS3Bucket_Security_policy (63.54s)
--- PASS: TestAccS3Bucket_Security_updateACL (43.17s)
--- PASS: TestAccS3Bucket_Security_updateGrant (68.96s)
--- PASS: TestAccS3Bucket_Tags_basic (74.49s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (100.46s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (231.29s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (250.71s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44
Update CHANGELOG for #22604
4bfd949
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from aa9d623 to b582a8f Compare February 5, 2022 04:12
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from b582a8f to 2b82923 Compare February 6, 2022 22:18
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 566113b to 9879354 Compare February 6, 2022 22:56
@anGie44 anGie44 force-pushed the f-s3-bucket-replication-config-deprecation branch from 9879354 to baec1e1 Compare February 7, 2022 00:09
@anGie44 anGie44 merged commit 1afd8f6 into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-replication-config-deprecation branch February 7, 2022 01:15
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
Update CHANGELOG.md for #22604
400170c
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @YakDriver @ewbankkit