Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only acceleration_status argument #22610

Merged
merged 5 commits into from
Feb 6, 2022
Merged

r/s3_bucket: read-only acceleration_status argument #22610

merged 5 commits into from
Feb 6, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 16, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (15.92s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (170.79s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (173.46s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (174.41s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (173.31s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (173.51s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (103.19s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (15.04s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (102.43s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (103.17s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (158.84s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (250.25s)

--- PASS: TestAccS3BucketDataSource_basic (93.30s)
--- PASS: TestAccS3BucketDataSource_website (92.71s)

--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (388.23s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (104.63s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (92.88s)

--- PASS: TestAccS3BucketInventory_basic (105.09s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (105.51s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (104.33s)

--- PASS: TestAccS3BucketMetric_basic (102.63s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (16.29s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (172.37s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (174.48s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (174.31s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (172.99s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (171.45s)

--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (120.11s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (104.80s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (129.65s)
--- PASS: TestAccS3BucketNotification_queue (132.34s)
--- PASS: TestAccS3BucketNotification_topic (102.56s)
--- PASS: TestAccS3BucketNotification_update (188.99s)

--- PASS: TestAccS3BucketObjectDataSource_allParams (91.84s)
--- PASS: TestAccS3BucketObjectDataSource_basic (87.66s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (94.17s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (91.41s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (91.21s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (162.88s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (163.53s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (92.44s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (88.20s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (92.39s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (92.30s)

--- PASS: TestAccS3BucketObject_acl (255.57s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (94.12s)
--- PASS: TestAccS3BucketObject_content (103.96s)
--- PASS: TestAccS3BucketObject_contentBase64 (89.63s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (93.29s)
--- PASS: TestAccS3BucketObject_empty (104.30s)
--- PASS: TestAccS3BucketObject_etagEncryption (102.77s)
--- PASS: TestAccS3BucketObject_ignoreTags (170.08s)
--- PASS: TestAccS3BucketObject_kms (102.29s)
--- PASS: TestAccS3BucketObject_metadata (257.10s)
--- PASS: TestAccS3BucketObject_noNameNoKey (23.41s)
--- PASS: TestAccS3BucketObject_nonVersioned (100.87s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (95.84s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (244.29s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (170.47s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (242.77s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (317.22s)
--- PASS: TestAccS3BucketObject_source (104.04s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (177.44s)
--- PASS: TestAccS3BucketObject_sse (105.50s)
--- PASS: TestAccS3BucketObject_storageClass (406.67s)
--- PASS: TestAccS3BucketObject_tags (328.40s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (319.54s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (325.90s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (316.99s)
--- PASS: TestAccS3BucketObject_updateSameFile (165.69s)
--- PASS: TestAccS3BucketObject_updates (178.30s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (175.50s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (167.00s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (90.98s)

--- PASS: TestAccS3BucketObjectsDataSource_all (171.09s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (170.17s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (169.88s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (171.78s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (169.30s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (171.63s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (173.14s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (172.91s)

--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (79.30s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (185.89s)
--- PASS: TestAccS3BucketOwnershipControls_basic (106.87s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (90.36s)

--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (377.74s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (283.23s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (296.42s)

--- PASS: TestAccS3BucketPolicy_basic (105.43s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (187.38s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (80.78s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (107.47s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (256.33s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (251.33s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (91.81s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (252.53s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (249.35s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (546.66s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (496.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (484.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (143.70s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (362.20s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (364.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (408.50s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (406.62s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (398.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (399.96s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (394.49s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (371.39s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (236.91s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (408.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (317.60s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (400.40s)

--- PASS: TestAccS3BucketVersioning_MFADelete (58.56s)
--- PASS: TestAccS3BucketVersioning_basic (97.08s)
--- PASS: TestAccS3BucketVersioning_disappears (87.84s)
--- PASS: TestAccS3BucketVersioning_update (145.05s)

--- PASS: TestAccS3Bucket_Basic_basic (62.94s)
--- PASS: TestAccS3Bucket_Basic_emptyString (62.95s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (96.49s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (95.48s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (96.41s)
--- PASS: TestAccS3Bucket_Basic_generatedName (35.14s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (66.70s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (39.08s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (62.93s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (49.48s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (69.01s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (232.74s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (182.17s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (108.62s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (91.56s)
--- PASS: TestAccS3Bucket_Manage_objectLock (151.91s)
--- PASS: TestAccS3Bucket_Manage_versioning (155.82s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (75.79s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (68.90s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (256.45s)
--- PASS: TestAccS3Bucket_Replication_basic (307.43s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (85.43s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (176.64s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (172.64s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (230.81s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (220.84s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (298.67s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (115.22s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (171.72s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (160.59s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (166.47s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (61.88s)
--- PASS: TestAccS3Bucket_Security_corsDelete (66.00s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (87.10s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (160.55s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (121.05s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (58.93s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (56.78s)
--- PASS: TestAccS3Bucket_Security_grantToACL (77.11s)
--- PASS: TestAccS3Bucket_Security_logging (99.01s)
--- PASS: TestAccS3Bucket_Security_policy (95.44s)
--- PASS: TestAccS3Bucket_Security_updateACL (58.94s)
--- PASS: TestAccS3Bucket_Security_updateGrant (103.94s)
--- PASS: TestAccS3Bucket_Tags_basic (38.09s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (62.16s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (140.13s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (176.02s)
--- PASS: TestAccS3Bucket_Web_redirect (169.72s)
--- PASS: TestAccS3Bucket_Web_routingRules (105.39s)
--- PASS: TestAccS3Bucket_Web_simple (166.59s)

--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 16, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jan 16, 2022
anGie44 added a commit that referenced this pull request Jan 16, 2022
@anGie44
Update CHANGELOG for #22610
58a307d
@anGie44 anGie44 changed the title r/s3_bucket: deprecate acceleration_status argument r/s3_bucket: read-only acceleration_status argument Jan 16, 2022
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22610
45beab1
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 58a307d to 45beab1 Compare January 26, 2022 22:21
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 50751d9 to 14e5051 Compare January 27, 2022 03:53
@anGie44
Copy link
Contributor Author

anGie44 commented Jan 27, 2022

Optionally preceded by #22617

@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 06:52
anGie44 added a commit that referenced this pull request Jan 27, 2022
@anGie44
Update CHANGELOG for #22610
20b5b69
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 14e5051 to 20b5b69 Compare January 27, 2022 06:55
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 20b5b69 to 6b3b135 Compare January 29, 2022 01:14
anGie44 added a commit that referenced this pull request Jan 29, 2022
@anGie44
Update CHANGELOG for #22610
8281f40
anGie44 added a commit that referenced this pull request Feb 1, 2022
@anGie44
Update CHANGELOG for #22610
934ba14
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 8281f40 to 934ba14 Compare February 1, 2022 01:49
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

% make testacc TESTS=TestAccS3Bucket PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket'  -timeout 180m
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestAccS3Bucket_Security_corsDelete (93.46s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (100.02s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (102.45s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (108.61s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (113.70s)
--- PASS: TestAccS3BucketVersioning_disappears (113.75s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (118.77s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (120.19s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (123.52s)
--- PASS: TestAccS3Bucket_Basic_generatedName (126.33s)
--- PASS: TestAccS3BucketVersioning_basic (127.69s)
--- PASS: TestAccS3BucketVersioning_MFADelete (131.76s)
--- PASS: TestAccS3Bucket_Security_logging (137.68s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (144.28s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (69.87s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (79.37s)
--- PASS: TestAccS3Bucket_Manage_objectLock (212.60s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (225.93s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (127.45s)
--- PASS: TestAccS3BucketOwnershipControls_basic (116.06s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (137.70s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (135.05s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (190.93s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (183.38s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (122.23s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (304.36s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (310.93s)
--- PASS: TestAccS3BucketVersioning_update (318.43s)
--- PASS: TestAccS3Bucket_Tags_basic (121.99s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (208.97s)
--- PASS: TestAccS3Bucket_Manage_versioning (221.78s)
--- PASS: TestAccS3Bucket_Web_routingRules (207.13s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (76.20s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (89.79s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (108.24s)
--- PASS: TestAccS3Bucket_Web_redirect (293.65s)
--- PASS: TestAccS3Bucket_Basic_emptyString (105.82s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (170.73s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (216.67s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (169.34s)
--- PASS: TestAccS3Bucket_Basic_basic (113.71s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (154.10s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (336.02s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (110.65s)
--- PASS: TestAccS3BucketNotification_topic (105.59s)
--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (66.75s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (101.78s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (79.51s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (512.62s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (3.80s)
--- PASS: TestAccS3BucketPolicy_basic (94.77s)
--- PASS: TestAccS3BucketNotification_update (214.14s)
--- PASS: TestAccS3BucketCorsConfiguration_SingleRule (72.68s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (142.89s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (1.80s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (148.50s)
--- PASS: TestAccS3BucketDataSource_basic (53.74s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (120.51s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (118.93s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (145.53s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (315.59s)
--- PASS: TestAccS3BucketDataSource_website (53.67s)
--- PASS: TestAccS3BucketCorsConfiguration_disappears (44.27s)
--- PASS: TestAccS3BucketCorsConfiguration_basic (48.46s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (105.24s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (342.02s)
--- PASS: TestAccS3Bucket_Security_updateACL (108.76s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (91.59s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (100.52s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (2.24s)
--- PASS: TestAccS3Bucket_Security_policy (177.86s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (47.88s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (50.27s)
--- PASS: TestAccS3BucketCorsConfiguration_MultipleRules (47.49s)
--- PASS: TestAccS3Bucket_Replication_basic (413.14s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (87.66s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (46.31s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (82.43s)
--- PASS: TestAccS3BucketMetric_basic (50.24s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (50.32s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (49.46s)
--- PASS: TestAccS3BucketInventory_basic (50.84s)
--- PASS: TestAccS3BucketNotification_queue (91.86s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (82.24s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (599.67s)
--- PASS: TestAccS3BucketCorsConfiguration_update (125.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (367.28s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (133.75s)
--- PASS: TestAccS3BucketNotification_eventbridge (44.76s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (65.98s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (80.64s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (47.90s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (64.91s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (101.19s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (60.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (439.52s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (178.54s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (89.56s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (52.89s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (146.41s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (81.92s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (31.56s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (32.16s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (81.27s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (112.59s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (80.26s)
--- PASS: TestAccS3Bucket_Security_updateGrant (100.38s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (305.04s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (56.55s)
--- PASS: TestAccS3Bucket_Security_grantToACL (56.16s)
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (18.65s)
--- PASS: TestAccS3Bucket_Web_simple (93.43s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (95.10s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (296.47s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (298.06s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (295.08s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (313.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (298.13s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (286.67s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (288.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (333.42s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (328.27s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (343.43s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (684.10s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (275.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	1151.594s

anGie44
anGie44 commented Feb 2, 2022
View reviewed changes
.changelog/22610.txt Outdated Show resolved Hide resolved
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 8bc33c7 to 929d20a Compare February 3, 2022 18:47
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22610
1ab1551
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 929d20a to 16d6066 Compare February 3, 2022 22:45
anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44
Update CHANGELOG for #22610
e6e7838
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 16d6066 to 9da880b Compare February 5, 2022 03:17
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 5, 2022

Output of updated acceptance tests:

--- PASS: TestAccS3BucketAccelerateConfiguration_basic (34.96s)
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (35.35s)
--- PASS: TestAccS3BucketAccelerateConfiguration_update (59.25s)

@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 9da880b to e6a0e41 Compare February 6, 2022 21:43
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 6, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-deprecate-acceleration-status branch from 23c6242 to d6a082a Compare February 6, 2022 22:03
@anGie44 anGie44 merged commit 3b1e0be into main Feb 6, 2022
@anGie44 anGie44 deleted the f-s3-bucket-deprecate-acceleration-status branch February 6, 2022 22:39
github-actions bot pushed a commit that referenced this pull request Feb 6, 2022
Update CHANGELOG.md for #22610
ffbfa3f
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @YakDriver @ewbankkit