Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22385 elasticache redis 6 regexp validation fix #22670

Closed
wants to merge 1 commit into from

Conversation

errcmd
Copy link

@errcmd errcmd commented Jan 19, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22385

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/elasticache Issues and PRs that pertain to the elasticache service. labels Jan 19, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @errcmd 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2022
@ktham
Copy link
Contributor

ktham commented Jan 24, 2022

@errcmd Can you add the corresponding test cases for your change?

@bschaatsbergen
Copy link
Member

I'll pick this PR up to solve both #23729 and #22385

@galindro
Copy link

galindro commented May 19, 2022

Hey guys, what is preventing you from merge this PR?

@ewbankkit
Copy link
Contributor

@errcmd Thanks for the contribution 🎉 👏.
Superseded by #23734.

@ewbankkit ewbankkit closed this Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS has changed Elasticache Redis versioning again
6 participants