Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust aws_dynamodb_table CreateTable LimitExceededException handling for different error messaging #2274

Merged
merged 2 commits into from
Nov 15, 2017

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 14, 2017

The AWS API is returning multiple, similar messages for DynamoDB throttling vs hitting the account limit. This "regression" was introduced in 130cdfe.

Closes #1776
Closes #2146

// Subscriber limit exceeded: There is a limit of 256 tables per subscriber
// Do not error out on this similar throttling message:
// Subscriber limit exceeded: Only 10 tables can be created, updated, or deleted simultaneously
if strings.Contains(awsErr.Message(), "Subscriber limit exceeded:") && !strings.Contains(awsErr.Message(), "simultaneously") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind tightening this a little bit, just to make sure we don't match an error we don't want to match? e.g. can be created, updated, or deleted simultaneously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem at all - will update shortly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem at all - will update shortly

@radeksimko radeksimko added bug Addresses a defect in current functionality. waiting-response Maintainers are waiting on response from community or contributor. size/XS Managed by automation to categorize the size of a PR. labels Nov 15, 2017
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2017

Updated message matching pushed. 👍

@radeksimko radeksimko removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 15, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@radeksimko radeksimko merged commit 22b2c68 into hashicorp:master Nov 15, 2017
@bflad bflad deleted the dynamodb_limitexceededexception branch December 1, 2017 15:34
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants