r/api_gateway_domain_name: Add support for Regional API Endpoints #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
the
enhancement
radeksimko
changed the title
radeksimko
added
the
size/M
Ninir
suggested changes
Nov 21, 2017
| "endpoint_configuration": { | ||
| Type: schema.TypeSet, | ||
| //Type: schema.TypeSet, | ||
| //Optional: true, |
There was a problem hiding this comment.
These 2 lines should be removed
| "regional_certificate_name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ConflictsWith: []string{"certificate_arn", "regional_certificate_name", "certificate_name"}, |
There was a problem hiding this comment.
Nitpick: don't you want to conflict with regional_certificate_arn instead?
| @@ -61,7 +75,12 @@ func resourceAwsApiGatewayDomainName() *schema.Resource { | |||
| "certificate_arn": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
| ConflictsWith: []string{"certificate_body", "certificate_chain", "certificate_name", "certificate_private_key"}, | |||
| ConflictsWith: []string{"certificate_body", "certificate_chain", "certificate_name", "certificate_private_key", "regional_certificate_arn"}, | |||
There was a problem hiding this comment.
Don't we want to conflict with regional_certificate_name also?
| "regional_certificate_arn": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ConflictsWith: []string{"certificate_body", "certificate_chain", "certificate_name", "certificate_private_key", "regional_certificate_name"}, |
There was a problem hiding this comment.
Don't we want to conflict with certificate_arn also?
bflad
added
the
service/apigateway
bflad
added
the
waiting-response
|
This functionality was implemented in #2866 and will release in v1.20.0 of the AWS provider later this week. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Regional Endpoints in API GW