aws_ec2_route_table_association: use retry logic on newly created resource

[thatderek]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22479
Closes #21629
Closes #21683
Closes #21978

Output from acceptance testing:

➜  terraform-provider-aws git:(ec2-vpc-route-table-association-retry-logic) ✗ make testacc TESTS=TestAccEC2RouteTableAssociation PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2RouteTableAssociation'  -timeout 180m
=== RUN   TestAccEC2RouteTableAssociation_Subnet_basic
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_basic
=== RUN   TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_Gateway_basic
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_basic
=== RUN   TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_disappears
=== PAUSE TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Subnet_basic
=== CONT  TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== CONT  TestAccEC2RouteTableAssociation_Gateway_basic
=== CONT  TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
--- PASS: TestAccEC2RouteTableAssociation_disappears (20.55s)
--- PASS: TestAccEC2RouteTableAssociation_Subnet_basic (21.85s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_basic (25.67s)
--- PASS: TestAccEC2RouteTableAssociation_Subnet_changeRouteTable (33.67s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_changeRouteTable (197.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	197.739s
➜  terraform-provider-aws git:(ec2-vpc-route-table-association-retry-logic) ✗

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccEC2RouteTableAssociation_ PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2RouteTableAssociation_'  -timeout 180m
=== RUN   TestAccEC2RouteTableAssociation_Subnet_basic
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_basic
=== RUN   TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_Gateway_basic
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_basic
=== RUN   TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== PAUSE TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== RUN   TestAccEC2RouteTableAssociation_disappears
=== PAUSE TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Subnet_basic
=== CONT  TestAccEC2RouteTableAssociation_Gateway_changeRouteTable
=== CONT  TestAccEC2RouteTableAssociation_disappears
=== CONT  TestAccEC2RouteTableAssociation_Gateway_basic
=== CONT  TestAccEC2RouteTableAssociation_Subnet_changeRouteTable
--- PASS: TestAccEC2RouteTableAssociation_Subnet_basic (41.46s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_basic (45.30s)
--- PASS: TestAccEC2RouteTableAssociation_disappears (53.14s)
--- PASS: TestAccEC2RouteTableAssociation_Gateway_changeRouteTable (69.14s)
--- PASS: TestAccEC2RouteTableAssociation_Subnet_changeRouteTable (70.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        74.535s

[ewbankkit]

@thatderek Thanks for the contribution 🎉 👏.

[thatderek]

And thanks for the clean up on that @ewbankkit . I feel like I keep creating more work for you rather than less, but know I'm looking at the changes you do and learning from them for whatever I end up trying to PR next.

[ewbankkit]

@thatderek No worries. We need to document some of this stuff better.

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.