Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/guardduty: update to aws_s3_bucket_acl #23044

Merged
merged 1 commit into from
Feb 9, 2022
Merged

tests/guardduty: update to aws_s3_bucket_acl #23044

merged 1 commit into from
Feb 9, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 8, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22997
Relates #22537
Relates #20433

Output from acceptance testing (had to run these in the Organizations-only account...maybe they should only run there since there seems to be a guarduty detector that can't be removed in the main account):

--- PASS: TestAccGuardDuty_serial (710.14s)
    --- PASS: TestAccGuardDuty_serial/OrganizationAdminAccount (1.47s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationAdminAccount/basic (1.47s)
    --- PASS: TestAccGuardDuty_serial/ThreatIntelSet (154.76s)
        --- PASS: TestAccGuardDuty_serial/ThreatIntelSet/basic (66.08s)
        --- PASS: TestAccGuardDuty_serial/ThreatIntelSet/tags (88.68s)
    --- PASS: TestAccGuardDuty_serial/Member (27.37s)
        --- PASS: TestAccGuardDuty_serial/Member/basic (27.37s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteOnUpdate (0.00s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteDisassociate (0.00s)
        --- SKIP: TestAccGuardDuty_serial/Member/invitationMessage (0.00s)
    --- PASS: TestAccGuardDuty_serial/PublishingDestination (69.16s)
        --- PASS: TestAccGuardDuty_serial/PublishingDestination/disappears (34.18s)
        --- PASS: TestAccGuardDuty_serial/PublishingDestination/basic (34.98s)
    --- PASS: TestAccGuardDuty_serial/InviteAccepter (0.00s)
        --- SKIP: TestAccGuardDuty_serial/InviteAccepter/basic (0.00s)
    --- PASS: TestAccGuardDuty_serial/Filter (134.16s)
        --- PASS: TestAccGuardDuty_serial/Filter/basic (35.11s)
        --- PASS: TestAccGuardDuty_serial/Filter/update (31.66s)
        --- PASS: TestAccGuardDuty_serial/Filter/tags (49.78s)
        --- PASS: TestAccGuardDuty_serial/Filter/disappears (17.61s)
    --- PASS: TestAccGuardDuty_serial/IPSet (151.41s)
        --- PASS: TestAccGuardDuty_serial/IPSet/basic (64.50s)
        --- PASS: TestAccGuardDuty_serial/IPSet/tags (86.91s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (0.35s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/basic (0.19s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (0.16s)
    --- PASS: TestAccGuardDuty_serial/Detector (171.45s)
        --- PASS: TestAccGuardDuty_serial/Detector/basic (53.74s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasources_s3logs (29.55s)
        --- PASS: TestAccGuardDuty_serial/Detector/tags (42.95s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasource_basic (28.84s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasource_id (16.38s)

@github-actions github-actions bot added service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Feb 8, 2022
@anGie44 anGie44 marked this pull request as ready for review February 9, 2022 00:35
ewbankkit
ewbankkit approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccGuardDuty_ PKG=guardduty
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/guardduty/... -v -count 1 -parallel 20 -run='TestAccGuardDuty_'  -timeout 180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/PublishingDestination
=== RUN   TestAccGuardDuty_serial/PublishingDestination/basic
=== RUN   TestAccGuardDuty_serial/PublishingDestination/disappears
=== RUN   TestAccGuardDuty_serial/InviteAccepter
=== RUN   TestAccGuardDuty_serial/InviteAccepter/basic
    guardduty_test.go:69: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
=== RUN   TestAccGuardDuty_serial/OrganizationAdminAccount
=== RUN   TestAccGuardDuty_serial/OrganizationAdminAccount/basic
    acctest.go:681: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/basic
    acctest.go:681: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs
    acctest.go:681: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccGuardDuty_serial/ThreatIntelSet
=== RUN   TestAccGuardDuty_serial/ThreatIntelSet/basic
=== RUN   TestAccGuardDuty_serial/ThreatIntelSet/tags
=== RUN   TestAccGuardDuty_serial/Detector
=== RUN   TestAccGuardDuty_serial/Detector/basic
=== RUN   TestAccGuardDuty_serial/Detector/datasources_s3logs
=== RUN   TestAccGuardDuty_serial/Detector/tags
=== RUN   TestAccGuardDuty_serial/Detector/datasource_basic
=== RUN   TestAccGuardDuty_serial/Detector/datasource_id
=== RUN   TestAccGuardDuty_serial/Filter
=== RUN   TestAccGuardDuty_serial/Filter/basic
=== RUN   TestAccGuardDuty_serial/Filter/update
=== RUN   TestAccGuardDuty_serial/Filter/tags
=== RUN   TestAccGuardDuty_serial/Filter/disappears
=== RUN   TestAccGuardDuty_serial/IPSet
=== RUN   TestAccGuardDuty_serial/IPSet/basic
=== RUN   TestAccGuardDuty_serial/IPSet/tags
=== RUN   TestAccGuardDuty_serial/Member
=== RUN   TestAccGuardDuty_serial/Member/inviteDisassociate
    guardduty_test.go:69: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
=== RUN   TestAccGuardDuty_serial/Member/invitationMessage
    guardduty_test.go:69: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
=== RUN   TestAccGuardDuty_serial/Member/basic
=== RUN   TestAccGuardDuty_serial/Member/inviteOnUpdate
    guardduty_test.go:69: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
--- PASS: TestAccGuardDuty_serial (837.08s)
    --- PASS: TestAccGuardDuty_serial/PublishingDestination (83.23s)
        --- PASS: TestAccGuardDuty_serial/PublishingDestination/basic (43.85s)
        --- PASS: TestAccGuardDuty_serial/PublishingDestination/disappears (39.37s)
    --- PASS: TestAccGuardDuty_serial/InviteAccepter (0.00s)
        --- SKIP: TestAccGuardDuty_serial/InviteAccepter/basic (0.00s)
    --- PASS: TestAccGuardDuty_serial/OrganizationAdminAccount (0.18s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationAdminAccount/basic (0.18s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (2.96s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/basic (0.14s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (2.83s)
    --- PASS: TestAccGuardDuty_serial/ThreatIntelSet (179.63s)
        --- PASS: TestAccGuardDuty_serial/ThreatIntelSet/basic (77.68s)
        --- PASS: TestAccGuardDuty_serial/ThreatIntelSet/tags (101.94s)
    --- PASS: TestAccGuardDuty_serial/Detector (202.09s)
        --- PASS: TestAccGuardDuty_serial/Detector/basic (60.94s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasources_s3logs (33.91s)
        --- PASS: TestAccGuardDuty_serial/Detector/tags (51.84s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasource_basic (33.50s)
        --- PASS: TestAccGuardDuty_serial/Detector/datasource_id (21.90s)
    --- PASS: TestAccGuardDuty_serial/Filter (147.32s)
        --- PASS: TestAccGuardDuty_serial/Filter/basic (42.35s)
        --- PASS: TestAccGuardDuty_serial/Filter/update (34.03s)
        --- PASS: TestAccGuardDuty_serial/Filter/tags (51.38s)
        --- PASS: TestAccGuardDuty_serial/Filter/disappears (19.56s)
    --- PASS: TestAccGuardDuty_serial/IPSet (196.09s)
        --- PASS: TestAccGuardDuty_serial/IPSet/basic (77.01s)
        --- PASS: TestAccGuardDuty_serial/IPSet/tags (119.08s)
    --- PASS: TestAccGuardDuty_serial/Member (25.58s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteDisassociate (0.00s)
        --- SKIP: TestAccGuardDuty_serial/Member/invitationMessage (0.00s)
        --- PASS: TestAccGuardDuty_serial/Member/basic (25.58s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteOnUpdate (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	840.598s

@anGie44 anGie44 added this to the v4.0.0 milestone Feb 9, 2022
@anGie44 anGie44 merged commit af7626e into main Feb 9, 2022
@anGie44 anGie44 deleted the td-guardduty-s3-bucket-acl-tests branch February 9, 2022 13:52
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/guardduty Issues and PRs that pertain to the guardduty service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit