Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dms task lifecycle #2305

Closed

Conversation

chrisjharding
Copy link
Contributor

@chrisjharding chrisjharding commented Nov 15, 2017

Closes #2236

It adds lifecycle behavior to dms replication tasks. This behavior is switched under the handle_task_lifecycle param so it can be turned off if not desirable. When enabled, it will start the task after creating it. When a modification is needed, it will stop the task prior to modifying it, then resume the task. It also stops the task before deletion.

First attempt. To test this, it actually requires running the dms task which means setting up real dms endpoints and having real data to migrate.

Currently, the tests are failing due to remote-exec not being available. I need the remote exec on the bastion to populate the db with data to migrate.

$ TF_LOG=DEBUG TF_ACC=1 go test ./aws -v -run=TestAccAwsDmsReplicationTaskHandleLifecycle -timeout 60m

--- FAIL: TestAccAwsDmsReplicationTaskHandleLifecycle (2.83s)
	testing.go:503: Step 0 error: Configuration is invalid.

		Warnings: []string(nil)

		Errors: []string{"1 error(s) occurred:\n\n* aws_instance.bastion: provisioner remote-exec couldn't be found"}
FAIL
exit status 1

One last note, I have had to copy in a hardcoded rsa key as the tls provider is not available when running these tests.

Is anyone able to advise on how I can use remote-exec provisioner with an aws instance inside AWS ACC tests please?

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR. labels Nov 16, 2017
@danielnitz
Copy link

really looking forward for this to make it into master!

@Zoey4560
Copy link

Excited for this as well! Stuck on the same bug. Any ideas on timeframe, or what's blocking this?

@jbergknoff-rival
Copy link
Contributor

@bflad any chance you or another maintainer could review this PR/give feedback on test strategy? This seems like a very useful feature to have.

@pancochea
Copy link

We are facing the same issue. We cannot manage DMS tasks on terraform cloud as it's impossible to apply changes to the tasks until the plugin manages the lifecycle.

Base automatically changed from master to main January 23, 2021 00:55
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:55
@ewbankkit
Copy link
Contributor

Closing as stale due to inactivity.

@ewbankkit ewbankkit closed this Aug 30, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMS task modification lifecycle
8 participants