Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/elb: update to aws_s3_bucket_acl #23051

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 9, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22997
Relates #22537
Relates #20433

Output from acceptance testing:

--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (85.49s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (85.70s)

@github-actions github-actions bot added service/elb Issues and PRs that pertain to the elb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Feb 9, 2022
@anGie44 anGie44 marked this pull request as ready for review February 9, 2022 01:37
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccELBLoadBalancer_AccessLogs_ PKG=elb   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBLoadBalancer_AccessLogs_'  -timeout 180m
=== RUN   TestAccELBLoadBalancer_AccessLogs_enabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_enabled
=== RUN   TestAccELBLoadBalancer_AccessLogs_disabled
=== PAUSE TestAccELBLoadBalancer_AccessLogs_disabled
=== CONT  TestAccELBLoadBalancer_AccessLogs_disabled
=== CONT  TestAccELBLoadBalancer_AccessLogs_enabled
--- PASS: TestAccELBLoadBalancer_AccessLogs_disabled (91.28s)
--- PASS: TestAccELBLoadBalancer_AccessLogs_enabled (93.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	97.467s

@anGie44 anGie44 modified the milestones: v3.74.2, v4.0.0 Feb 9, 2022
@anGie44 anGie44 merged commit 44e932f into main Feb 9, 2022
@anGie44 anGie44 deleted the td-elb-s3-bucket-acl-tests branch February 9, 2022 13:54
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants