-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/cloudfront: update to aws_s3_bucket_acl
#23068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudFrontDistribution_originPolicyOrdered\|TestAccCloudFrontDistribution_customOrigin\|TestAccCloudFrontDistribution_multiOrigin\|TestAccCloudFrontDistribution_originGroups\|TestAccCloudFrontDistribution_Origin_connectionAttempts\|TestAccCloudFrontDistribution_Origin_connectionTimeout\|TestAccCloudFrontDistribution_Origin_originShield\|TestAccCloudFrontDistribution_originPolicyDefault\|TestAccCloudFrontDistributionDataSource_basic' PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontDistribution_originPolicyOrdered\|TestAccCloudFrontDistribution_customOrigin\|TestAccCloudFrontDistribution_multiOrigin\|TestAccCloudFrontDistribution_originGroups\|TestAccCloudFrontDistribution_Origin_connectionAttempts\|TestAccCloudFrontDistribution_Origin_connectionTimeout\|TestAccCloudFrontDistribution_Origin_originShield\|TestAccCloudFrontDistribution_originPolicyDefault\|TestAccCloudFrontDistributionDataSource_basic -timeout 180m
=== RUN TestAccCloudFrontDistributionDataSource_basic
=== PAUSE TestAccCloudFrontDistributionDataSource_basic
=== RUN TestAccCloudFrontDistribution_customOrigin
=== PAUSE TestAccCloudFrontDistribution_customOrigin
=== RUN TestAccCloudFrontDistribution_originPolicyDefault
=== PAUSE TestAccCloudFrontDistribution_originPolicyDefault
=== RUN TestAccCloudFrontDistribution_originPolicyOrdered
=== PAUSE TestAccCloudFrontDistribution_originPolicyOrdered
=== RUN TestAccCloudFrontDistribution_multiOrigin
=== PAUSE TestAccCloudFrontDistribution_multiOrigin
=== RUN TestAccCloudFrontDistribution_Origin_connectionAttempts
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionAttempts
=== RUN TestAccCloudFrontDistribution_Origin_connectionTimeout
=== PAUSE TestAccCloudFrontDistribution_Origin_connectionTimeout
=== RUN TestAccCloudFrontDistribution_Origin_originShield
=== PAUSE TestAccCloudFrontDistribution_Origin_originShield
=== RUN TestAccCloudFrontDistribution_originGroups
=== PAUSE TestAccCloudFrontDistribution_originGroups
=== CONT TestAccCloudFrontDistributionDataSource_basic
=== CONT TestAccCloudFrontDistribution_Origin_connectionAttempts
=== CONT TestAccCloudFrontDistribution_multiOrigin
=== CONT TestAccCloudFrontDistribution_Origin_connectionTimeout
=== CONT TestAccCloudFrontDistribution_Origin_originShield
=== CONT TestAccCloudFrontDistribution_originPolicyDefault
=== CONT TestAccCloudFrontDistribution_originPolicyOrdered
=== CONT TestAccCloudFrontDistribution_customOrigin
=== CONT TestAccCloudFrontDistribution_originGroups
--- PASS: TestAccCloudFrontDistribution_multiOrigin (335.78s)
--- PASS: TestAccCloudFrontDistribution_customOrigin (336.51s)
--- PASS: TestAccCloudFrontDistribution_originGroups (342.24s)
--- PASS: TestAccCloudFrontDistributionDataSource_basic (343.14s)
--- PASS: TestAccCloudFrontDistribution_originPolicyDefault (376.43s)
--- PASS: TestAccCloudFrontDistribution_originPolicyOrdered (380.63s)
--- PASS: TestAccCloudFrontDistribution_Origin_connectionTimeout (390.26s)
--- PASS: TestAccCloudFrontDistribution_Origin_connectionAttempts (456.59s)
--- PASS: TestAccCloudFrontDistribution_Origin_originShield (457.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 460.609s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #22997
Relates #22537
Relates #20433
Output from acceptance testing: