Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_lb: mark subnets as ForceNew for network load balancers #2310

Merged
merged 3 commits into from
Nov 16, 2017
Merged

r/aws_lb: mark subnets as ForceNew for network load balancers #2310

merged 3 commits into from
Nov 16, 2017

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Nov 15, 2017 •
edited
Loading

Replaces #2293

Subnets cannot be updated on Load Balancers of type network at this time:

  • Documentation
  • Conditionally mark subnets as ForceNew if the load_balancer_type is set to network

Fixes #1925

@catsby
Add test verifying broken subnet setting for aws_lb
e4b4f87 
- subnets can't be updated for lbs of type `network`
- the `UPDATE` method tries to update the `subnets`, which fails, even
on first apply
@catsby
fix ordering
ad0d5ef
@catsby
Mark Subnets as forcenew for network load balancers
498a539
@catsby catsby mentioned this pull request Nov 15, 2017
Closed
3 tasks
@catsby
Copy link
Contributor Author

catsby commented Nov 15, 2017

cc @DaveBlooman , this should address #1925

vancluever
vancluever approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@catsby catsby mentioned this pull request Nov 15, 2017
Closed
radeksimko
radeksimko approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

aws/resource_aws_lb.go
return nil
}

if "" == diff.Id() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, but diff.Id() == "" would make more sense. 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old defensive habit from my Ruby days, trying to save myself from typos like

if variable = "something" {
  //stuff 
}

when I meant

if variable == "something" {
  //stuff
}

@radeksimko radeksimko added this to the v1.3.0 milestone Nov 16, 2017
@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Nov 16, 2017
@catsby catsby merged commit cf42ac1 into master Nov 16, 2017
@catsby catsby deleted the f-fb-network-subnet-forcenew branch November 16, 2017 16:02
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vancluever vancluever vancluever approved these changes

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

SetSubnets not allowed on LB type network
3 participants
@catsby @radeksimko @vancluever