Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #22978 to release/3.x #23253

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Backport of #22978 to release/3.x #23253

merged 2 commits into from
Feb 17, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 17, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23186.
Relates #22978.
Relates #22500.
Relates #22378.

Output from acceptance testing:

% make testacc TESTS=TestAccWAFRuleGroup_ PKG=waf
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/waf/... -v -count 1 -parallel 20 -run='TestAccWAFRuleGroup_'  -timeout 180m
=== RUN   TestAccWAFRuleGroup_basic
=== PAUSE TestAccWAFRuleGroup_basic
=== RUN   TestAccWAFRuleGroup_changeNameForceNew
=== PAUSE TestAccWAFRuleGroup_changeNameForceNew
=== RUN   TestAccWAFRuleGroup_disappears
=== PAUSE TestAccWAFRuleGroup_disappears
=== RUN   TestAccWAFRuleGroup_changeActivatedRules
=== PAUSE TestAccWAFRuleGroup_changeActivatedRules
=== RUN   TestAccWAFRuleGroup_tags
=== PAUSE TestAccWAFRuleGroup_tags
=== RUN   TestAccWAFRuleGroup_noActivatedRules
=== PAUSE TestAccWAFRuleGroup_noActivatedRules
=== CONT  TestAccWAFRuleGroup_basic
=== CONT  TestAccWAFRuleGroup_changeActivatedRules
=== CONT  TestAccWAFRuleGroup_tags
=== CONT  TestAccWAFRuleGroup_disappears
=== CONT  TestAccWAFRuleGroup_noActivatedRules
=== CONT  TestAccWAFRuleGroup_changeNameForceNew
--- PASS: TestAccWAFRuleGroup_noActivatedRules (20.62s)
--- PASS: TestAccWAFRuleGroup_basic (28.36s)
--- PASS: TestAccWAFRuleGroup_disappears (30.10s)
--- PASS: TestAccWAFRuleGroup_tags (40.85s)
--- PASS: TestAccWAFRuleGroup_changeNameForceNew (47.31s)
--- PASS: TestAccWAFRuleGroup_changeActivatedRules (49.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/waf	53.248s
% make testacc TESTS=TestAccWAFRegionalRuleGroup_ PKG=wafregional
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafregional/... -v -count 1 -parallel 20 -run='TestAccWAFRegionalRuleGroup_'  -timeout 180m
=== RUN   TestAccWAFRegionalRuleGroup_basic
=== PAUSE TestAccWAFRegionalRuleGroup_basic
=== RUN   TestAccWAFRegionalRuleGroup_tags
=== PAUSE TestAccWAFRegionalRuleGroup_tags
=== RUN   TestAccWAFRegionalRuleGroup_changeNameForceNew
=== PAUSE TestAccWAFRegionalRuleGroup_changeNameForceNew
=== RUN   TestAccWAFRegionalRuleGroup_disappears
=== PAUSE TestAccWAFRegionalRuleGroup_disappears
=== RUN   TestAccWAFRegionalRuleGroup_changeActivatedRules
=== PAUSE TestAccWAFRegionalRuleGroup_changeActivatedRules
=== RUN   TestAccWAFRegionalRuleGroup_noActivatedRules
=== PAUSE TestAccWAFRegionalRuleGroup_noActivatedRules
=== CONT  TestAccWAFRegionalRuleGroup_basic
=== CONT  TestAccWAFRegionalRuleGroup_disappears
=== CONT  TestAccWAFRegionalRuleGroup_changeActivatedRules
=== CONT  TestAccWAFRegionalRuleGroup_noActivatedRules
=== CONT  TestAccWAFRegionalRuleGroup_tags
=== CONT  TestAccWAFRegionalRuleGroup_changeNameForceNew
--- PASS: TestAccWAFRegionalRuleGroup_noActivatedRules (30.20s)
--- PASS: TestAccWAFRegionalRuleGroup_disappears (53.94s)
--- PASS: TestAccWAFRegionalRuleGroup_basic (55.49s)
--- PASS: TestAccWAFRegionalRuleGroup_changeActivatedRules (70.48s)
--- PASS: TestAccWAFRegionalRuleGroup_changeNameForceNew (71.54s)
--- PASS: TestAccWAFRegionalRuleGroup_tags (82.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	86.446s

@github-actions github-actions bot added service/waf Issues and PRs that pertain to the waf service. size/XS Managed by automation to categorize the size of a PR. labels Feb 17, 2022
@ewbankkit ewbankkit added this to the v3.74.3 milestone Feb 17, 2022
@ewbankkit ewbankkit merged commit 297c504 into release/3.x Feb 17, 2022
@ewbankkit ewbankkit deleted the b-backport-22978 branch February 17, 2022 19:29
github-actions bot pushed a commit that referenced this pull request Feb 17, 2022
@github-actions
Copy link

This functionality has been released in v3.74.3 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/waf Issues and PRs that pertain to the waf service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants