Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Add custom_ca_bundle #23279

Merged
merged 7 commits into from
Feb 18, 2022
Merged

provider: Add custom_ca_bundle #23279

merged 7 commits into from
Feb 18, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Feb 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23229
Closes #23224
Relates hashicorp/aws-sdk-go-base#119
Relates #23212
Relates #23282

Output from acceptance testing:

% make testacc TESTS=TestAccProvider PKG_NAME=./internal/acctest
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/acctest/... -v -count 1 -parallel 20 -run='TestAccProvider'  -timeout 180m
--- PASS: TestAccProvider_Region_awsGovCloudUs (23.01s)
--- PASS: TestAccProvider_Region_stsRegion (23.13s)
--- PASS: TestAccProvider_Region_awsC2S (23.15s)
--- PASS: TestAccProvider_Region_awsSC2S (23.75s)
--- PASS: TestAccProvider_Region_awsChina (24.11s)
--- PASS: TestAccProvider_Region_awsCommercial (24.78s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_multiple (28.30s)
--- PASS: TestAccProvider_IgnoreTags_emptyBlock (28.42s)
--- PASS: TestAccProvider_IgnoreTagsKeys_one (29.22s)
--- PASS: TestAccProvider_IgnoreTagsKeys_multiple (29.73s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_none (30.31s)
--- PASS: TestAccProvider_DefaultTagsTags_one (30.31s)
--- PASS: TestAccProvider_DefaultTagsTags_multiple (30.31s)
--- PASS: TestAccProvider_DefaultTags_emptyBlock (30.31s)
--- PASS: TestAccProvider_IgnoreTagsKeys_none (30.33s)
--- PASS: TestAccProvider_unusualEndpoints (30.35s)
--- PASS: TestAccProvider_IgnoreTagsKeyPrefixes_one (31.28s)
--- PASS: TestAccProvider_endpoints (31.32s)
--- PASS: TestAccProvider_AssumeRole_empty (33.60s)
--- PASS: TestAccProvider_DefaultAndIgnoreTags_emptyBlocks (12.23s)
--- PASS: TestAccProvider_DefaultTagsTags_none (12.35s)
--- PASS: TestAccProvider_fipsEndpoint (39.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	41.489s

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. labels Feb 18, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Feb 18, 2022
@YakDriver YakDriver marked this pull request as draft February 18, 2022 18:09
@YakDriver YakDriver requested a review from gdavison February 18, 2022 18:12
@ewbankkit ewbankkit added this to the v4.2.0 milestone Feb 18, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 18, 2022
@YakDriver YakDriver requested a review from gdavison February 18, 2022 19:47
@YakDriver YakDriver marked this pull request as ready for review February 18, 2022 19:48
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@YakDriver YakDriver merged commit 6a765e3 into main Feb 18, 2022
@YakDriver YakDriver deleted the f-add-ca-custom-bundle branch February 18, 2022 20:35
github-actions bot pushed a commit that referenced this pull request Feb 18, 2022
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider: Add parameter custom_ca_bundle Unable to plan/apply with a custom CA bundle defined
3 participants