r/instance: prevent double encoding when updating user_data or user_data_base64
#23362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
anGie44
force-pushed
the
b-ec2-instance-user-data-encoding
branch
from
58cc8b0 to
86c75cb
Compare
github-actions
bot
added
the
verify
anGie44
force-pushed
the
b-ec2-instance-user-data-encoding
branch
2 times, most recently
from
5dc98e0 to
9c38d4e
Compare
github-actions
bot
removed
the
verify
anGie44
force-pushed
the
b-ec2-instance-user-data-encoding
branch
from
9c38d4e to
846c020
Compare
anGie44
added
the
enhancement
anGie44
force-pushed
the
b-ec2-instance-user-data-encoding
branch
from
ca1b982 to
cb97cdc
Compare
github-actions
bot
added
size/L
anGie44
commented
Feb 24, 2022
| @@ -3583,6 +3651,39 @@ func TestAccEC2Instance_UserData_update(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccEC2Instance_UserData_stringToEncodedString(t *testing.T) { | |||
There was a problem hiding this comment.
this test might not be realistic?
|
Relates #18043. |
ewbankkit
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2Instance_userDataBase64\|TestAccEC2Instance_UserData\|TestAccEC2Instance_basic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2Instance_userDataBase64\|TestAccEC2Instance_UserData\|TestAccEC2Instance_basic -timeout 180m
=== RUN TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN TestAccEC2Instance_userDataBase64
=== PAUSE TestAccEC2Instance_userDataBase64
=== RUN TestAccEC2Instance_userDataBase64_updateWithBashFile
=== PAUSE TestAccEC2Instance_userDataBase64_updateWithBashFile
=== RUN TestAccEC2Instance_userDataBase64_updateWithZipFile
=== PAUSE TestAccEC2Instance_userDataBase64_updateWithZipFile
=== RUN TestAccEC2Instance_userDataBase64_update
=== PAUSE TestAccEC2Instance_userDataBase64_update
=== RUN TestAccEC2Instance_UserData
=== PAUSE TestAccEC2Instance_UserData
=== RUN TestAccEC2Instance_UserData_update
=== PAUSE TestAccEC2Instance_UserData_update
=== RUN TestAccEC2Instance_UserData_stringToEncodedString
=== PAUSE TestAccEC2Instance_UserData_stringToEncodedString
=== RUN TestAccEC2Instance_UserData_emptyStringToUnspecified
=== PAUSE TestAccEC2Instance_UserData_emptyStringToUnspecified
=== RUN TestAccEC2Instance_UserData_unspecifiedToEmptyString
=== PAUSE TestAccEC2Instance_UserData_unspecifiedToEmptyString
=== CONT TestAccEC2Instance_basic
=== CONT TestAccEC2Instance_UserData
=== CONT TestAccEC2Instance_UserData_emptyStringToUnspecified
--- PASS: TestAccEC2Instance_basic (96.48s)
=== CONT TestAccEC2Instance_UserData_unspecifiedToEmptyString
--- PASS: TestAccEC2Instance_UserData (129.83s)
=== CONT TestAccEC2Instance_userDataBase64_updateWithZipFile
--- PASS: TestAccEC2Instance_UserData_emptyStringToUnspecified (170.68s)
=== CONT TestAccEC2Instance_userDataBase64_update
--- PASS: TestAccEC2Instance_UserData_unspecifiedToEmptyString (163.16s)
=== CONT TestAccEC2Instance_UserData_stringToEncodedString
--- PASS: TestAccEC2Instance_userDataBase64_updateWithZipFile (215.12s)
=== CONT TestAccEC2Instance_UserData_update
--- PASS: TestAccEC2Instance_userDataBase64_update (214.74s)
=== CONT TestAccEC2Instance_userDataBase64_updateWithBashFile
--- PASS: TestAccEC2Instance_UserData_stringToEncodedString (235.36s)
=== CONT TestAccEC2Instance_userDataBase64
--- PASS: TestAccEC2Instance_UserData_update (213.35s)
--- PASS: TestAccEC2Instance_userDataBase64 (116.52s)
--- PASS: TestAccEC2Instance_userDataBase64_updateWithBashFile (235.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 627.223s
|
I can't thank you enough for your help and contribution. 👍 🙇 |
YakDriver
pushed a commit
that referenced
this pull request
Feb 28, 2022
YakDriver
pushed a commit
that referenced
this pull request
Feb 28, 2022
|
This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #23305
Relates #23315 (comment)
Output from acceptance testing: