Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: TeamCity configuration #23418

Merged
merged 40 commits into from
Jul 14, 2022
Merged

ci: TeamCity configuration #23418

merged 40 commits into from
Jul 14, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Mar 1, 2022

Merges initial TeamCity configuration. Adds "full build" and "pull request" build types.

gdavison added 26 commits November 9, 2021 14:38
@gdavison
Initial TeamCity DSL configuration
e0d29ba
@gdavison
Renames Composite config
ef61bd6
@gdavison
Adds alternate region
a40891e
@gdavison
Adds ACM root domain and limited privileges role ARN
96636f1
@gdavison
Adds parameter run_nightly_build
56e66d6
@gdavison
Adds trigger_day parameter and defaults to Sun-Thu
a14fa0d
@gdavison
Adds alternate account parameters
b4517df
@gdavison
Renames Composite build to FullBuild and adds PullRequest
70aaa76
@gdavison
Corrects pull request script
5bee823
@gdavison
Makes timeout a constant
ce95ae2
@gdavison
Kotlin scoping confuses me
ebe132c
@gdavison
Renames AWS authentication parameters
257761f
@gdavison
Renames account lock ids
5c70f9e
@gdavison
Actually adds pull request test runner script
3fc3a97
@gdavison
Missed a set of lock ids
305d446
@gdavison
Adds VPC lock
0d2079d
@gdavison
Adds VPC lock to more services
4e7e6c0
@gdavison
Adds VPC lock to eks
f963e3e
@gdavison
Adds VPC lock to opsworks
9de64c5
@gdavison
Renames config to configservice and adds VPC lock to more services
6ded96f
@gdavison
Fixes service naming
c6ba6e9
@gdavison
Adds VPC lock to additional services and adds parallelism override
6cdb21e
@gdavison
Renames services
4dadaa9
@gdavison
Adds VPC lock to more services
f965221
@gdavison
Ensures goenv is up-to-date
b1842d0
@gdavison
Sets env.TF_LOG
40d46ac
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. labels Mar 1, 2022
ewbankkit
ewbankkit approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Is there (internal) documentation on how to modify this when a new AWS service is supported?

@ewbankkit
Copy link
Contributor

services_all.kt looks like something that should ultimately be generated: #24054.

@github-actions github-actions bot added generators Relates to code generators. and removed generators Relates to code generators. labels Jun 21, 2022
@gdavison gdavison requested a review from ewbankkit June 21, 2022 17:25
@github-actions github-actions bot added the generators Relates to code generators. label Jun 21, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 21, 2022
YakDriver
YakDriver reviewed Jun 21, 2022
View reviewed changes
internal/generate/teamcity/README.md
@@ -0,0 +1,26 @@
# TeamCity Acceptance Test Configuration Generator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea (readme) in each generator. I've added some but I probably need to go back and document better.

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Jul 13, 2022
@gdavison gdavison merged commit b9fd7ab into main Jul 14, 2022
@gdavison gdavison deleted the teamcity branch July 14, 2022 06:27
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 14, 2022
@ewbankkit ewbankkit mentioned this pull request Jul 18, 2022
Closed
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver left review comments

@ewbankkit ewbankkit Awaiting requested review from ewbankkit

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @ewbankkit @YakDriver