Add Multi-AZ support for RDS clusters #23533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output from acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerDevice' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerDevice -timeout 120m MYDEBUG: resourceAwsNetworkManagerLink() === RUN TestAccAWSNetworkManagerDevice_basic === PAUSE TestAccAWSNetworkManagerDevice_basic === RUN TestAccAWSNetworkManagerDevice_tags === PAUSE TestAccAWSNetworkManagerDevice_tags === CONT TestAccAWSNetworkManagerDevice_basic === CONT TestAccAWSNetworkManagerDevice_tags --- PASS: TestAccAWSNetworkManagerDevice_basic (79.77s) --- PASS: TestAccAWSNetworkManagerDevice_tags (127.77s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 128.780s
Output from acceptance test: $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkManagerTransitGatewayRegistration' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkManagerTransitGatewayRegistration -timeout 120m === RUN TestAccAWSNetworkManagerTransitGatewayRegistration_basic === PAUSE TestAccAWSNetworkManagerTransitGatewayRegistration_basic === CONT TestAccAWSNetworkManagerTransitGatewayRegistration_basic --- PASS: TestAccAWSNetworkManagerTransitGatewayRegistration_basic (237.71s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 238.925s
R004: ResourceData.Set() incompatible value type: *github.com/aws/aws-sdk-go/service/networkmanager.Location resource_aws_networkmanager_device.go resource_aws_networkmanager_site.go R006: RetryFunc should include RetryableError() handling or be removed resource_aws_networkmanager_transit_gateway_registration
Output from acceptance test: $ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManager' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManager -timeout 120m === RUN TestAccDataSourceAWSNetworkManagerGlobalNetwork === PAUSE TestAccDataSourceAWSNetworkManagerGlobalNetwork === CONT TestAccDataSourceAWSNetworkManagerGlobalNetwork --- PASS: TestAccDataSourceAWSNetworkManagerGlobalNetwork (45.09s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 46.280s
Output from acceptance tests: $ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManagerSite' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManagerSite -timeout 120m === RUN TestAccDataSourceAWSNetworkManagerSite === PAUSE TestAccDataSourceAWSNetworkManagerSite === CONT TestAccDataSourceAWSNetworkManagerSite --- PASS: TestAccDataSourceAWSNetworkManagerSite (44.82s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 45.806s
Output from acceptance test: $ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSNetworkManagerDevice' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSNetworkManagerDevice -timeout 120m === RUN TestAccDataSourceAWSNetworkManagerDevice === PAUSE TestAccDataSourceAWSNetworkManagerDevice === CONT TestAccDataSourceAWSNetworkManagerDevice --- PASS: TestAccDataSourceAWSNetworkManagerDevice (62.20s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 63.223s
Action Required: Terraform 0.12 Syntax hashicorp#8950 AT003: acceptance test function name should include underscore
R005: multiple ResourceData.HasChange() calls can be combined with single HasChanges() call
website/docs/d/networkmanager_device.markdown website/docs/d/networkmanager_global_network.markdown website/docs/d/networkmanager_site.markdown website/docs/r/networkmanager_device.markdown website/docs/r/networkmanager_global_network.markdown website/docs/r/networkmanager_site.markdown website/docs/r/networkmanager_transit_gateway_registration.markdown
github-actions
bot
added
service/amplify
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
|
Rebasing the PR turned it into a mess, I'll see if I can recreate it. My bad. See: #23684 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #23475
Output from acceptance testing: