r/aws_transfer_server: Add pre_display_banner and post_display_banner attributes

[cesarpball]

This is my first contribution - feedback is welcome.

Thank you!

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23492

Release note for CHANGELOG

release-note:enhancement
resource/aws_transfer_server: Add `pre_display_banner` and `post_display_banner` attributes

Output from acceptance testing:

$make testacc TESTARGS='-run=TestAccTransferServer_DisplayBanners' ACCTEST_PARALLELISM=5 PKG=transfer

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 5  -run=TestAccTransferServer_DisplayBanners -timeout 180m
=== RUN   TestAccTransferServer_DisplayBanners
--- PASS: TestAccTransferServer_DisplayBanners (272.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	276.941s

...

[github-actions]

Welcome @cesarpball 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@cesarpball Thanks for the contribution 🎉 👏.
Overall it's in great shape.
I renamed the new arguments to pre_authentication_login_banner and post_authentication_login_banner so as to match the AWS API parameter names and ensured that the new test case is serialized against all the other Transfer Server tests.
I went ahead and pushed these changes so we can get this PR merged for the next release.

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccTransfer_serial/Server/basic PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/basic'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (209.58s)
    --- PASS: TestAccTransfer_serial/Server (209.58s)
        --- PASS: TestAccTransfer_serial/Server/basic (209.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	213.152s
% make testacc TESTS=TestAccTransfer_serial/Server/AuthenticationLoginBanners PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/AuthenticationLoginBanners'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
--- PASS: TestAccTransfer_serial (196.75s)
    --- PASS: TestAccTransfer_serial/Server (196.75s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (196.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	200.265s

[cesarpball]

@cesarpball Thanks for the contribution 🎉 👏. Overall it's in great shape. I renamed the new arguments to pre_authentication_login_banner and post_authentication_login_banner so as to match the AWS API parameter names and ensured that the new test case is serialized against all the other Transfer Server tests. I went ahead and pushed these changes so we can get this PR merged for the next release.

Excellent, thanks for your feedback!!!. I will consider to match exactly with the API names for my next contribution :-)

[github-actions]

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.