Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider infrastructure for Amazon Keyspaces #23663

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11221

Output from acceptance testing:

f-keyspaces-service-support $ make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
go: downloading github.com/aws/aws-sdk-go v1.43.17
go: downloading github.com/aws/aws-sdk-go-v2/service/route53domains v1.12.0
?       github.com/hashicorp/terraform-provider-aws     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/acctest    11.374s
?       github.com/hashicorp/terraform-provider-aws/internal/attrmap    [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/conns      0.969s
ok      github.com/hashicorp/terraform-provider-aws/internal/create     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable      (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/experimental/sync  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/flex       0.497s
ok      github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters 5.410s
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   0.867s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     6.237s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    8.801s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acm        14.089s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     24.363s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        15.733s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    19.137s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 24.787s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       26.380s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling     25.435s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  27.893s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    21.760s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  19.492s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  22.568s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    21.724s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena     19.725s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        20.297s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans   16.647s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     13.630s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      15.525s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    14.053s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      18.352s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloud9     19.659s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol       18.881s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation     21.423s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 16.812s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2 17.911s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        20.897s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 18.719s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 18.385s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs     14.643s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact       17.807s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  18.040s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecommit 17.784s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codedeploy 20.463s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       19.647s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections        20.990s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications      19.874s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    14.889s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 15.357s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/configservice      14.527s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    16.171s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        17.083s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange       19.475s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       18.095s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   21.554s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dax        20.003s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  22.701s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm 21.530s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      22.073s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dlm        18.125s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        19.039s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdb      17.755s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 15.370s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   19.201s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        36.407s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        23.470s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic  16.377s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        12.690s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        11.391s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        12.469s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        16.044s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk   17.613s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch      22.907s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder  20.034s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        16.327s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      22.858s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        16.004s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     18.150s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   13.076s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        14.949s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        20.463s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   16.668s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glacier    20.547s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  19.675s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       23.011s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/grafana    28.926s
?       github.com/hashicorp/terraform-provider-aws/internal/service/greengrass [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  29.943s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        11.110s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      5.799s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       4.663s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector  10.575s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        10.458s
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics       [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotevents  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      13.403s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect       16.441s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    24.723s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics   18.871s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2 20.768s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo       23.189s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        18.131s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      16.421s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     16.952s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels  15.400s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager     11.429s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  14.086s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie      19.469s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     18.411s
?       github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert       20.716s
?       github.com/hashicorp/terraform-provider-aws/internal/service/medialive  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage       19.126s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediastore 21.304s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   20.098s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       20.883s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 19.897s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       21.568s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    16.477s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    18.828s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     18.006s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opsworks   20.193s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      18.757s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/outposts   18.415s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint   21.500s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pricing    16.177s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/qldb       19.670s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 21.940s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        20.673s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        15.911s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   19.482s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups     16.705s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi   17.987s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    18.249s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     19.089s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig       18.842s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness   22.044s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    13.549s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 18.376s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  15.575s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 17.763s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  15.800s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/schemas    18.324s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     18.576s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        17.409s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo     17.856s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     15.927s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   17.661s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      11.909s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        17.963s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        16.917s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     15.954s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/signer     17.371s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   17.864s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        21.575s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sqs        16.695s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        18.829s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   18.518s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway     16.746s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        18.440s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/swf        18.444s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 21.170s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite    19.059s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   19.634s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/waf        9.101s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafregional        8.052s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      11.574s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/worklink   9.608s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 11.853s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       11.828s
ok      github.com/hashicorp/terraform-provider-aws/internal/tags       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/tfresource 32.279s
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/verify     8.112s
?       github.com/hashicorp/terraform-provider-aws/version     [no test files]

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2022
@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.
The only question I had was around the naming of the (future) resources and data sources, aws_keyspaces_thing or aws_cassandra_thing?

@ewbankkit
Copy link
Contributor

After some internal discussions we have decided to stick with keyspaces for new resource names.

@ewbankkit ewbankkit merged commit 120cae3 into hashicorp:main Mar 14, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 14, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants