r/cloudwatchlogs_subscription_filter - add plan time validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccCloudWatchLogsSubscriptionFilter_ PKG=cloudwatchlogs

--- PASS: TestAccCloudWatchLogsSubscriptionFilter_basic (52.59s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_disappears (64.59s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup (68.77s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream (79.52s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_distribution (85.46s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_roleARN (115.66s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose (125.55s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccCloudWatchLogsSubscriptionFilter_ PKG=cloudwatchlogs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatchlogs/... -v -count 1 -parallel 2 -run='TestAccCloudWatchLogsSubscriptionFilter_'  -timeout 180m
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_basic
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_basic
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_disappears
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_disappears
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_distribution
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_distribution
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_roleARN
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_roleARN
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_basic
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_roleARN
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_basic (37.17s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_roleARN (98.02s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_distribution
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_distribution (53.52s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose (131.60s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup (29.84s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_disappears
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_disappears (28.76s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream (89.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs	245.757s

GovCloud

% hashigovaws 
Setting HashiCorp AWS GovCloud credentials
ewbankkit@ewbankkit-C02F408DML85 terraform-provider-aws % make testacc TESTS=TestAccCloudWatchLogsSubscriptionFilter_ PKG=cloudwatchlogs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatchlogs/... -v -count 1 -parallel 2 -run='TestAccCloudWatchLogsSubscriptionFilter_'  -timeout 180m
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_basic
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_basic
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_disappears
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_disappears
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_distribution
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_distribution
=== RUN   TestAccCloudWatchLogsSubscriptionFilter_roleARN
=== PAUSE TestAccCloudWatchLogsSubscriptionFilter_roleARN
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_basic
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_basic (39.51s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_roleARN
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisStream (63.86s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_roleARN (86.85s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_disappears
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_DestinationARN_kinesisDataFirehose (69.20s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_disappears (29.52s)
=== CONT  TestAccCloudWatchLogsSubscriptionFilter_distribution
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_Disappears_logGroup (28.65s)
--- PASS: TestAccCloudWatchLogsSubscriptionFilter_distribution (51.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs	215.243s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.