-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_keyspaces_keyspace #23770
Conversation
5e81f11
to
91ab3a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG=keyspaces TESTS=TestAccKeyspacesKeyspace_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run='TestAccKeyspacesKeyspace_' -timeout 180m
=== RUN TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== CONT TestAccKeyspacesKeyspace_basic
=== CONT TestAccKeyspacesKeyspace_tags
--- PASS: TestAccKeyspacesKeyspace_basic (67.18s)
=== CONT TestAccKeyspacesKeyspace_disappears
--- PASS: TestAccKeyspacesKeyspace_tags (91.21s)
--- PASS: TestAccKeyspacesKeyspace_disappears (60.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 132.009s
GovCloud
% make testacc PKG=keyspaces TESTS=TestAccKeyspacesKeyspace_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run='TestAccKeyspacesKeyspace_' -timeout 180m
=== RUN TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== CONT TestAccKeyspacesKeyspace_basic
=== CONT TestAccKeyspacesKeyspace_tags
=== CONT TestAccKeyspacesKeyspace_basic
keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
--- SKIP: TestAccKeyspacesKeyspace_basic (1.00s)
=== CONT TestAccKeyspacesKeyspace_tags
keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
=== CONT TestAccKeyspacesKeyspace_disappears
--- SKIP: TestAccKeyspacesKeyspace_tags (1.00s)
=== CONT TestAccKeyspacesKeyspace_disappears
keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
--- SKIP: TestAccKeyspacesKeyspace_disappears (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 4.506s
Sweeper
% make sweep SWEEPARGS=-sweep-run=aws_keyspaces_keyspace SWEEP=us-west-2
...
2022/03/21 09:24:46 [DEBUG] Completed Sweeper (aws_keyspaces_keyspace) in region (us-west-2) in 1.67538533s
2022/03/21 09:24:46 Completed Sweepers for region (us-west-2) in 1.675526652s
2022/03/21 09:24:46 Sweeper Tests for region (us-west-2) ran successfully:
- aws_keyspaces_keyspace
ok github.com/hashicorp/terraform-provider-aws/internal/sweep 6.952s
@roberth-k Thanks for the contribution 🎉 👏.
|
This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #11221
Output from acceptance testing: