Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: configuration for intra-region Transit Gateway Peering #24000

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

gmichelo
Copy link
Contributor

@gmichelo gmichelo commented Apr 2, 2022

Issue #23828 made me think that the intra-region Peering use-case
is not straight forward. Operators might assume they need to
configure the Acceptor to the Peering Attachment that Terraform creates.
In fact, AWS creates two Peering Attachment resources, one for the
Creator side and one for the Acceptor side. So, the a Data Source
is needed to find the second Acceptor side's attachment and then
use it to configure the Acceptor resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23828

Output from acceptance testing: not needed as it's a new example config and not a code change.

Issue hashicorp#23828 made me think that the intra-region Peering use-case
is not straight forward. Operators might assume they need to
configure the Acceptor to the Peering Attachment that Terraform creates.
In fact, AWS creates two Peering Attachment resources, one for the
Creator side and one for the Acceptor side. So, the a Data Source
is needed to find the second Acceptor side's attachment and then
use it to configure the Acceptor resource.

Closes: hashicorp#23828
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Apr 2, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @BigMikes 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BigMikes 👋 Thank you for taking the time to raise this! I added a few comments, mostly around some typos and whitespace issues.

examples/transit-gateway-intra-region-peering/main.tf Outdated Show resolved Hide resolved
examples/transit-gateway-intra-region-peering/main.tf Outdated Show resolved Hide resolved
examples/transit-gateway-intra-region-peering/main.tf Outdated Show resolved Hide resolved
examples/transit-gateway-intra-region-peering/main.tf Outdated Show resolved Hide resolved
examples/transit-gateway-intra-region-peering/main.tf Outdated Show resolved Hide resolved
examples/transit-gateway-intra-region-peering/README.md Outdated Show resolved Hide resolved
@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2022
@gmichelo gmichelo requested a review from justinretzolk June 19, 2022 18:21
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you again for your contribution!

@justinretzolk justinretzolk merged commit 87b2ab2 into hashicorp:main Jul 6, 2022
@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 6, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intra-Region Peering seems not to work for TGW
2 participants