-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: configuration for intra-region Transit Gateway Peering #24000
examples: configuration for intra-region Transit Gateway Peering #24000
Conversation
Issue hashicorp#23828 made me think that the intra-region Peering use-case is not straight forward. Operators might assume they need to configure the Acceptor to the Peering Attachment that Terraform creates. In fact, AWS creates two Peering Attachment resources, one for the Creator side and one for the Acceptor side. So, the a Data Source is needed to find the second Acceptor side's attachment and then use it to configure the Acceptor resource. Closes: hashicorp#23828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @BigMikes 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BigMikes 👋 Thank you for taking the time to raise this! I added a few comments, mostly around some typos and whitespace issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you again for your contribution!
This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Issue #23828 made me think that the intra-region Peering use-case
is not straight forward. Operators might assume they need to
configure the Acceptor to the Peering Attachment that Terraform creates.
In fact, AWS creates two Peering Attachment resources, one for the
Creator side and one for the Acceptor side. So, the a Data Source
is needed to find the second Acceptor side's attachment and then
use it to configure the Acceptor resource.
Community Note
Closes #23828
Output from acceptance testing: not needed as it's a new example config and not a code change.