Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider infrastructure for Amazon CloudWatch Evidently #24169

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Add provider infrastructure for Amazon CloudWatch Evidently #24169

merged 4 commits into from
Apr 12, 2022

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22624

Output from acceptance testing:

$ make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
?       github.com/hashicorp/terraform-provider-aws     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/acctest    (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/attrmap    [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/conns      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/create     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable      (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/experimental/sync  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/flex       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acm        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloud9     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2 (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatchlogs     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecommit (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codedeploy (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/configservice      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dax        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dlm        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdb      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glacier    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/grafana    (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/service/greengrass [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics       [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotevents  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2 (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert       (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/service/medialive  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediastore (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opsworks   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/outposts   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pricing    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/qldb       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/schemas    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/signer     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sqs        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/swf        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/waf        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafregional        (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/worklink   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/tags       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/tfresource (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/verify     (cached)
ok      github.com/hashicorp/terraform-provider-aws/names       0.013s
?       github.com/hashicorp/terraform-provider-aws/version     [no test files]
...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Apr 10, 2022
@ewbankkit
Copy link
Contributor

@YakDriver FYI for #24054.

@ewbankkit ewbankkit closed this Apr 12, 2022
@ewbankkit ewbankkit reopened this Apr 12, 2022
ewbankkit
ewbankkit approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./internal/provider 
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	0.799s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2617987 into hashicorp:main Apr 12, 2022
@github-actions github-actions bot added this to the v4.10.0 milestone Apr 12, 2022
@GlennChia GlennChia deleted the f-aws_cloudwatchevidently-service-support branch April 12, 2022 14:18
@github-actions
Copy link

This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code partner Contribution from a partner. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GlennChia @ewbankkit @DrFaust92 @justinretzolk