Adding support for table resource #24351

pranayw333 · 2022-04-21T22:08:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

github-actions

Welcome @pranayw333 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

ewbankkit · 2022-04-22T12:37:06Z

Similar: #24265.

This reverts commit a8c546d.

…e for schema definition attributes. Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_basic PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_basic' -timeout 180m === RUN TestAccKeyspacesTable_basic === PAUSE TestAccKeyspacesTable_basic === CONT TestAccKeyspacesTable_basic --- PASS: TestAccKeyspacesTable_basic (118.47s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 124.716s

Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_tags PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_tags' -timeout 180m === RUN TestAccKeyspacesTable_tags === PAUSE TestAccKeyspacesTable_tags === CONT TestAccKeyspacesTable_tags --- PASS: TestAccKeyspacesTable_tags (130.70s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 134.608s

Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_multipleColumns PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_multipleColumns' -timeout 180m === RUN TestAccKeyspacesTable_multipleColumns === PAUSE TestAccKeyspacesTable_multipleColumns === CONT TestAccKeyspacesTable_multipleColumns table_test.go:139: Step 1/2 error: Check failed: 12 errors occurred: * Check 11/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.1.name' expected "name", got "division" * Check 15/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.3.name' expected "division", got "manager_id" * Check 17/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.4.name' expected "project", got "name" * Check 19/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.5.name' expected "role", got "project" * Check 21/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.6.name' expected "pay_scale", got "vacation_hrs" * Check 22/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.6.type' expected "int", got "float" * Check 23/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.7.name' expected "vacation_hrs", got "pay_scale" * Check 24/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.7.type' expected "float", got "int" * Check 25/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.column.8.name' expected "manager_id", got "role" * Check 28/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.partition_key.0.name' expected "message", got "id" * Check 30/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.static_column.0.name' expected "role", got "pay_scale" * Check 31/31 error: aws_keyspaces_table.test: Attribute 'schema_definition.0.static_column.1.name' expected "pay_scale", got "role" --- FAIL: TestAccKeyspacesTable_multipleColumns (88.35s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 94.534s FAIL make: *** [testacc] Error 1

… attributes and ensure lowercase strings. Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_basic PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_basic' -timeout 180m === RUN TestAccKeyspacesTable_basic === PAUSE TestAccKeyspacesTable_basic === CONT TestAccKeyspacesTable_basic --- PASS: TestAccKeyspacesTable_basic (117.47s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 121.809s

Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_multipleColumns PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_multipleColumns' -timeout 180m === RUN TestAccKeyspacesTable_multipleColumns === PAUSE TestAccKeyspacesTable_multipleColumns === CONT TestAccKeyspacesTable_multipleColumns --- PASS: TestAccKeyspacesTable_multipleColumns (105.08s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 109.384s

…ges during Update.

…or the table.

Acceptance test output: % make testacc TESTS=TestAccKeyspacesTable_addColumns PKG=keyspaces ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesTable_addColumns' -timeout 180m === RUN TestAccKeyspacesTable_addColumns === PAUSE TestAccKeyspacesTable_addColumns === CONT TestAccKeyspacesTable_addColumns --- PASS: TestAccKeyspacesTable_addColumns (115.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 119.931s

ewbankkit

LGTM 🚀.

% make testacc TESTS=TestAccKeyspacesTable_ PKG=keyspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run='TestAccKeyspacesTable_'  -timeout 180m
=== RUN   TestAccKeyspacesTable_basic
=== PAUSE TestAccKeyspacesTable_basic
=== RUN   TestAccKeyspacesTable_disappears
=== PAUSE TestAccKeyspacesTable_disappears
=== RUN   TestAccKeyspacesTable_tags
=== PAUSE TestAccKeyspacesTable_tags
=== RUN   TestAccKeyspacesTable_multipleColumns
=== PAUSE TestAccKeyspacesTable_multipleColumns
=== RUN   TestAccKeyspacesTable_update
=== PAUSE TestAccKeyspacesTable_update
=== RUN   TestAccKeyspacesTable_addColumns
=== PAUSE TestAccKeyspacesTable_addColumns
=== RUN   TestAccKeyspacesTable_delColumns
=== PAUSE TestAccKeyspacesTable_delColumns
=== CONT  TestAccKeyspacesTable_basic
=== CONT  TestAccKeyspacesTable_update
--- PASS: TestAccKeyspacesTable_basic (105.06s)
=== CONT  TestAccKeyspacesTable_delColumns
--- PASS: TestAccKeyspacesTable_delColumns (143.91s)
=== CONT  TestAccKeyspacesTable_addColumns
--- PASS: TestAccKeyspacesTable_addColumns (114.99s)
=== CONT  TestAccKeyspacesTable_tags
--- PASS: TestAccKeyspacesTable_tags (126.74s)
=== CONT  TestAccKeyspacesTable_multipleColumns
--- PASS: TestAccKeyspacesTable_multipleColumns (102.18s)
=== CONT  TestAccKeyspacesTable_disappears
--- PASS: TestAccKeyspacesTable_disappears (89.17s)
--- PASS: TestAccKeyspacesTable_update (957.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	961.556s

ewbankkit · 2022-05-16T20:13:51Z

@pranayw333 Thanks for the contribution 🎉 👏.

pranayw333 · 2022-05-17T18:40:21Z

@pranayw333 Thanks for the contribution 🎉 👏.

@ewbankkit Thank you so much for help :)

github-actions · 2022-05-20T05:07:32Z

This functionality has been released in v4.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-20T02:32:24Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

[WIP] Adding support for table resource

a8c546d

github-actions bot reviewed Apr 21, 2022

View reviewed changes

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 22, 2022

Adding support for table resource

a7fe07e

pranayw333 force-pushed the main branch from 5689876 to a7fe07e Compare April 22, 2022 17:57

pranayw333 mentioned this pull request Apr 22, 2022

Amazon Managed Apache Cassandra Service / Keyspaces #11221

Closed

ewbankkit added 2 commits May 10, 2022 12:03

Revert "[WIP] Adding support for table resource"

0bd6195

This reverts commit a8c546d.

Merge commit '0bd61959d3f2d962e31abc3d5fbff3a0edb71d92' into HEAD

02c42ba

ewbankkit mentioned this pull request May 10, 2022

[WIP] New Resource: aws_keyspaces_table #24265

Closed

ewbankkit added 12 commits May 10, 2022 12:14

'FindTableInKeyspaceByName' -> 'FindTableByTwoPartKey'.

50254d8

r/aws_keyspaces_keyspace: Simplify waiting.

164e65d

Run 'make fmt'.

e26c118

r/aws_keyspaces_table: Add CRUD handlers.

ef70196

r/aws_keyspaces_table: Add simple acceptance tests.

47ff31d

r/aws_keyspaces_table: Additional attributes and expanders.

67f75f7

r/aws_keyspaces_table: Add flatteners.

f836371

Add CHANGELOG entry.

fb3caca

r/aws_keyspaces_table: Some arguments are Computed.

4e85094

Merge branch 'main' into HEAD

9dfe6ff

Add 'SuppressEquivalentStringCaseInsensitive'.

1dc9857

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels May 11, 2022

github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 11, 2022

This comment was marked as outdated.

Sign in to view

r/aws_keyspaces_table: Add documentation.

5c6463c

github-actions bot added the documentation Introduces or discusses updates to documentation. label May 11, 2022

ewbankkit and others added 15 commits May 12, 2022 08:25

Add 'TestAccKeyspacesTable_update'.

39286b5

Fixing go lint failure

7e099f7

r/aws_keyspaces_table: Add a 10s delay before polling for status chan…

ce1a693

…ges during Update.

r/aws_keyspaces_table: After 'ttl' is enabled, you can't disable it f…

44dfdc7

…or the table.

Document Keyspaces resource custom timeouts.

47cf75d

r/aws_keyspaces_table: Delete columns.

691e567

Merge commit '691e567a241ddf3490629d8ed17e3dd83edf5f3d' into HEAD

9956a24

r/aws_keyspaces_table: Correct CustomizeDiff.

5d6062c

r/aws_keyspaces_table: Increase default Update timeout to '30m'.

8afa88d

r/aws_keyspaces_keyspace: Retry Delete on ConflictException.

8103433

ewbankkit approved these changes May 16, 2022

View reviewed changes

ewbankkit merged commit c17a7f9 into hashicorp:main May 16, 2022

github-actions bot added this to the v4.15.0 milestone May 16, 2022

github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for table resource #24351

Adding support for table resource #24351

pranayw333 commented Apr 21, 2022 •

edited by ewbankkit

Loading

github-actions bot left a comment

ewbankkit commented Apr 22, 2022

This comment was marked as outdated.

ewbankkit left a comment

ewbankkit commented May 16, 2022

pranayw333 commented May 17, 2022

github-actions bot commented May 20, 2022

github-actions bot commented Jun 20, 2022

Adding support for table resource #24351

Adding support for table resource #24351

Conversation

pranayw333 commented Apr 21, 2022 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit commented Apr 22, 2022

This comment was marked as outdated.

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented May 16, 2022

pranayw333 commented May 17, 2022

github-actions bot commented May 20, 2022

github-actions bot commented Jun 20, 2022

pranayw333 commented Apr 21, 2022 •

edited by ewbankkit

Loading