Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/route53_record: updates to pass semgrep rule prefer-aws-go-sdk-pointer-conversion-assignment #24481

Merged
merged 1 commit into from
May 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12992

Output from acceptance testing:

$ semgrep
Running 31 rules...
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|31/31
ran 31 rules on 2344 files: 0 findings
make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccRoute53Record_ -timeout 180m
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN   TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN   TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN   TestAccRoute53Record_Basic_fqdn
=== PAUSE TestAccRoute53Record_Basic_fqdn
=== RUN   TestAccRoute53Record_Basic_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_Basic_trailingPeriodAndZoneID
=== RUN   TestAccRoute53Record_txtSupport
=== PAUSE TestAccRoute53Record_txtSupport
=== RUN   TestAccRoute53Record_spfSupport
=== PAUSE TestAccRoute53Record_spfSupport
=== RUN   TestAccRoute53Record_caaSupport
=== PAUSE TestAccRoute53Record_caaSupport
=== RUN   TestAccRoute53Record_dsSupport
=== PAUSE TestAccRoute53Record_dsSupport
=== RUN   TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN   TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN   TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN   TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN   TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN   TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN   TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN   TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN   TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN   TestAccRoute53Record_setIdentifierChange
=== PAUSE TestAccRoute53Record_setIdentifierChange
=== RUN   TestAccRoute53Record_aliasChange
=== PAUSE TestAccRoute53Record_aliasChange
=== RUN   TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN   TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53Record_doNotAllowOverwrite
=== PAUSE TestAccRoute53Record_doNotAllowOverwrite
=== RUN   TestAccRoute53Record_allowOverwrite
=== PAUSE TestAccRoute53Record_allowOverwrite
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53Record_Alias_vpcEndpoint
=== CONT  TestAccRoute53Record_Alias_s3
=== CONT  TestAccRoute53Record_dsSupport
=== CONT  TestAccRoute53Record_generatesSuffix
=== CONT  TestAccRoute53Record_nameChange
=== CONT  TestAccRoute53Record_typeChange
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
=== CONT  TestAccRoute53Record_Weighted_basic
=== CONT  TestAccRoute53Record_failover
=== CONT  TestAccRoute53Record_wildcard
=== CONT  TestAccRoute53Record_Latency_basic
=== CONT  TestAccRoute53Record_HealthCheckID_typeChange
=== CONT  TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== CONT  TestAccRoute53Record_Geolocation_basic
=== CONT  TestAccRoute53Record_Weighted_alias
=== CONT  TestAccRoute53Record_Alias_uppercase
=== CONT  TestAccRoute53Record_Basic_fqdn
=== CONT  TestAccRoute53Record_longTXTrecord
=== CONT  TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_basic (318.35s)
=== CONT  TestAccRoute53Record_caaSupport
--- PASS: TestAccRoute53Record_longTXTrecord (139.11s)
=== CONT  TestAccRoute53Record_spfSupport
--- PASS: TestAccRoute53Record_Latency_basic (721.95s)
=== CONT  TestAccRoute53Record_txtSupport
--- PASS: TestAccRoute53Record_Alias_elb (722.44s)
=== CONT  TestAccRoute53Record_Basic_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_generatesSuffix (754.83s)
=== CONT  TestAccRoute53Record_aliasChange
--- PASS: TestAccRoute53Record_failover (982.03s)
=== CONT  TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_Geolocation_basic (986.79s)
=== CONT  TestAccRoute53Record_allowOverwrite
--- PASS: TestAccRoute53Record_Weighted_basic (1205.12s)
=== CONT  TestAccRoute53Record_disappears
=== CONT  TestAccRoute53Record_doNotAllowOverwrite
--- PASS: TestAccRoute53Record_Alias_s3 (1205.17s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (1236.04s)
=== CONT  TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_dsSupport (1290.65s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_caaSupport (987.15s)
=== CONT  TestAccRoute53Record_setIdentifierChange
--- PASS: TestAccRoute53Record_Basic_fqdn (1335.71s)
=== CONT  TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_typeChange (1336.83s)
--- PASS: TestAccRoute53Record_Alias_uppercase (1337.78s)
--- PASS: TestAccRoute53Record_spfSupport (1266.74s)
--- PASS: TestAccRoute53Record_Basic_trailingPeriodAndZoneID (1041.87s)
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (1783.53s)
--- PASS: TestAccRoute53Record_wildcard (1783.93s)
--- PASS: TestAccRoute53Record_empty (805.90s)
--- PASS: TestAccRoute53Record_allowOverwrite (801.18s)
--- PASS: TestAccRoute53Record_txtSupport (1067.73s)
--- PASS: TestAccRoute53Record_doNotAllowOverwrite (604.68s)
--- PASS: TestAccRoute53Record_aliasChange (1070.94s)
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (537.73s)
--- PASS: TestAccRoute53Record_disappears (625.71s)
--- PASS: TestAccRoute53Record_underscored (518.21s)
--- PASS: TestAccRoute53Record_nameChange (1855.83s)
--- PASS: TestAccRoute53Record_Weighted_alias (1886.15s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (663.89s)
--- PASS: TestAccRoute53Record_setIdentifierChange (631.52s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (1983.08s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (2331.42s)

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR. labels Apr 30, 2022
@anGie44 anGie44 changed the title r/route53_record: updates to pass semgrep rule prefer-aws-go-sdk-pointer-conversion-assignment r/route53_record: updates to pass semgrep rule prefer-aws-go-sdk-pointer-conversion-assignment Apr 30, 2022
@anGie44 anGie44 marked this pull request as ready for review April 30, 2022 01:32
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v4.13.0 milestone May 3, 2022
@anGie44 anGie44 merged commit 2cd7cac into main May 3, 2022
@anGie44 anGie44 deleted the route53-semgrep-exclusions branch May 3, 2022 12:36
github-actions bot pushed a commit that referenced this pull request May 3, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants