-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_secretsmanager_secrets - new data source #24514
d/aws_secretsmanager_secrets - new data source #24514
Conversation
The failed website check does not seem to be related to this PR. |
Acceptance test output: % make testacc TESTS=TestAccSecretsManagerSecret_ PKG=secretsmanager ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 2 -run='TestAccSecretsManagerSecret_' -timeout 180m === RUN TestAccSecretsManagerSecret_basic === PAUSE TestAccSecretsManagerSecret_basic === RUN TestAccSecretsManagerSecret_withNamePrefix === PAUSE TestAccSecretsManagerSecret_withNamePrefix === RUN TestAccSecretsManagerSecret_description === PAUSE TestAccSecretsManagerSecret_description === RUN TestAccSecretsManagerSecret_basicReplica === PAUSE TestAccSecretsManagerSecret_basicReplica === RUN TestAccSecretsManagerSecret_overwriteReplica === PAUSE TestAccSecretsManagerSecret_overwriteReplica === RUN TestAccSecretsManagerSecret_kmsKeyID === PAUSE TestAccSecretsManagerSecret_kmsKeyID === RUN TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate === PAUSE TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate === RUN TestAccSecretsManagerSecret_rotationLambdaARN === PAUSE TestAccSecretsManagerSecret_rotationLambdaARN === RUN TestAccSecretsManagerSecret_rotationRules === PAUSE TestAccSecretsManagerSecret_rotationRules === RUN TestAccSecretsManagerSecret_tags === PAUSE TestAccSecretsManagerSecret_tags === RUN TestAccSecretsManagerSecret_policy === PAUSE TestAccSecretsManagerSecret_policy === CONT TestAccSecretsManagerSecret_basic === CONT TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate --- PASS: TestAccSecretsManagerSecret_basic (18.42s) === CONT TestAccSecretsManagerSecret_basicReplica --- PASS: TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate (27.96s) === CONT TestAccSecretsManagerSecret_kmsKeyID --- PASS: TestAccSecretsManagerSecret_basicReplica (16.00s) === CONT TestAccSecretsManagerSecret_overwriteReplica --- PASS: TestAccSecretsManagerSecret_kmsKeyID (28.97s) === CONT TestAccSecretsManagerSecret_description --- PASS: TestAccSecretsManagerSecret_description (27.78s) === CONT TestAccSecretsManagerSecret_tags --- PASS: TestAccSecretsManagerSecret_overwriteReplica (52.84s) === CONT TestAccSecretsManagerSecret_policy --- PASS: TestAccSecretsManagerSecret_tags (51.72s) === CONT TestAccSecretsManagerSecret_withNamePrefix --- PASS: TestAccSecretsManagerSecret_policy (52.35s) === CONT TestAccSecretsManagerSecret_rotationRules --- PASS: TestAccSecretsManagerSecret_withNamePrefix (15.90s) === CONT TestAccSecretsManagerSecret_rotationLambdaARN --- PASS: TestAccSecretsManagerSecret_rotationRules (55.66s) --- PASS: TestAccSecretsManagerSecret_rotationLambdaARN (54.30s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 210.547s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccSecretsManagerSecret_ PKG=secretsmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 2 -run='TestAccSecretsManagerSecret_' -timeout 180m
=== RUN TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== RUN TestAccSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccSecretsManagerSecret_withNamePrefix
=== RUN TestAccSecretsManagerSecret_description
=== PAUSE TestAccSecretsManagerSecret_description
=== RUN TestAccSecretsManagerSecret_basicReplica
=== PAUSE TestAccSecretsManagerSecret_basicReplica
=== RUN TestAccSecretsManagerSecret_overwriteReplica
=== PAUSE TestAccSecretsManagerSecret_overwriteReplica
=== RUN TestAccSecretsManagerSecret_kmsKeyID
=== PAUSE TestAccSecretsManagerSecret_kmsKeyID
=== RUN TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== PAUSE TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
=== RUN TestAccSecretsManagerSecret_rotationLambdaARN
=== PAUSE TestAccSecretsManagerSecret_rotationLambdaARN
=== RUN TestAccSecretsManagerSecret_rotationRules
=== PAUSE TestAccSecretsManagerSecret_rotationRules
=== RUN TestAccSecretsManagerSecret_tags
=== PAUSE TestAccSecretsManagerSecret_tags
=== RUN TestAccSecretsManagerSecret_policy
=== PAUSE TestAccSecretsManagerSecret_policy
=== CONT TestAccSecretsManagerSecret_basic
=== CONT TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate
--- PASS: TestAccSecretsManagerSecret_basic (18.42s)
=== CONT TestAccSecretsManagerSecret_basicReplica
--- PASS: TestAccSecretsManagerSecret_RecoveryWindowInDays_recreate (27.96s)
=== CONT TestAccSecretsManagerSecret_kmsKeyID
--- PASS: TestAccSecretsManagerSecret_basicReplica (16.00s)
=== CONT TestAccSecretsManagerSecret_overwriteReplica
--- PASS: TestAccSecretsManagerSecret_kmsKeyID (28.97s)
=== CONT TestAccSecretsManagerSecret_description
--- PASS: TestAccSecretsManagerSecret_description (27.78s)
=== CONT TestAccSecretsManagerSecret_tags
--- PASS: TestAccSecretsManagerSecret_overwriteReplica (52.84s)
=== CONT TestAccSecretsManagerSecret_policy
--- PASS: TestAccSecretsManagerSecret_tags (51.72s)
=== CONT TestAccSecretsManagerSecret_withNamePrefix
--- PASS: TestAccSecretsManagerSecret_policy (52.35s)
=== CONT TestAccSecretsManagerSecret_rotationRules
--- PASS: TestAccSecretsManagerSecret_withNamePrefix (15.90s)
=== CONT TestAccSecretsManagerSecret_rotationLambdaARN
--- PASS: TestAccSecretsManagerSecret_rotationRules (55.66s)
--- PASS: TestAccSecretsManagerSecret_rotationLambdaARN (54.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 210.547s
% make testacc TESTS=TestAccSecretsManagerSecretsDataSource_ PKG=secretsmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 20 -run='TestAccSecretsManagerSecretsDataSource_' -timeout 180m
=== RUN TestAccSecretsManagerSecretsDataSource_filter
=== PAUSE TestAccSecretsManagerSecretsDataSource_filter
=== CONT TestAccSecretsManagerSecretsDataSource_filter
--- PASS: TestAccSecretsManagerSecretsDataSource_filter (66.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 72.629s
@kamilturek Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24421.
Output from acceptance testing: