Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/fix PreconditionFailed errors on aws_cloudfront_distribution #24537

Merged
merged 2 commits into from
May 5, 2022
Merged

b/fix PreconditionFailed errors on aws_cloudfront_distribution #24537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11ec672
fix PreconditionFailed errors on aws_cloudfront_distribution
iandrewt May 4, 2022
41b231d
update CHANGELOG
iandrewt May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/24537.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_cloudfront_distribution: Fix PreconditionFailed errors when other CloudFront resources are changed before the distribution
```
23 changes: 23 additions & 0 deletions internal/service/cloudfront/distribution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,29 @@ func resourceDistributionUpdate(d *schema.ResourceData, meta interface{}) error
return nil
})

// Refresh our ETag if it is out of date and attempt update again
if tfawserr.ErrCodeEquals(err, cloudfront.ErrCodePreconditionFailed) {
getDistributionInput := &cloudfront.GetDistributionInput{
Id: aws.String(d.Id()),
}
var getDistributionOutput *cloudfront.GetDistributionOutput

log.Printf("[DEBUG] Refreshing CloudFront Distribution (%s) ETag", d.Id())
getDistributionOutput, err = conn.GetDistribution(getDistributionInput)

if err != nil {
return fmt.Errorf("error refreshing CloudFront Distribution (%s) ETag: %s", d.Id(), err)
}

if getDistributionOutput == nil {
return fmt.Errorf("error refreshing CloudFront Distribution (%s) ETag: empty response", d.Id())
}

params.IfMatch = getDistributionOutput.ETag

_, err = conn.UpdateDistribution(params)
}

// Propagate AWS Go SDK retried error, if any
if tfresource.TimedOut(err) {
_, err = conn.UpdateDistribution(params)
Expand Down
Loading