Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DirectoryService size parameter for MicrosoftAD #2458

Closed
wants to merge 2 commits into from

Conversation

philharle
Copy link

No description provided.

@philharle
Copy link
Author

Requires change in the aws-sdk-go project, see #2192

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 29, 2017
@bflad
Copy link
Contributor

bflad commented Feb 16, 2018

Hi @philharle 👋 sorry for the long delay in a maintainer review of this PR. It looks like the correct answer here was an Edition parameter instead of using Size as noted upstream in the SDK issue aws/aws-sdk-go#1664. Since this PR is invalid according to the AWS API and SDK, I'm going to close this.

The good news is that we have a tracking issue for supporting Edition in #2357 and a recently opened PR to implement this in #3421! 🎉

@bflad bflad closed this Feb 16, 2018
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants